packages: update mirage-crypto to 2.0.1 #731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING: replaces cstructs for strings, and changes rng generators' API Signed-off-by: Pau Ruiz Safont <[email protected]>
psafont
force-pushed
the
private/paus/stringy-crypto
branch
from
287c506 to
2c2d06c
Compare
|
What does it mean to replace ctruct with strings? The crypto package drops its cstruct dependency? But we have other packages that still use cstruct? |
In the context of the package it means cstructs are removed from the dependency, and its API now uses strings instead. This does not mean that the cstruct package is removed from the repository because it has a large use-base. |
last-genius
approved these changes
Jun 4, 2025
lindig
approved these changes
Jun 9, 2025
github-merge-queue bot
pushed a commit
to xapi-project/xen-api
that referenced
this pull request
Jun 10, 2025
Unfortunately mirage-crypto has accumulated breaking changes: - Cstructs have been replaced with strings - The digestif library has replaced ad-hoc hash implementation A deprecation has happened as well: - RNG initialization has changed Because there are breaking changes, xs-opam changes need to be introduced at the same time: xapi-project/xs-opam#731 Only xapi is affected by the breaking builds, so no other toolstack repositories have incoming PRs. I've tested builds with Smoke and validation tests: SR 218740 This means that the merge will be done as such: - Both PRs are approved - First I will merge xs-opam will be emrged (with failing CI) - Then this PR will be merged with the merge train that runs tests before actually merging. - CI is rerun manually on xs-opam to make it green again After merging both xenserver's CI should create a successful build with both PR included
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING: replaces cstructs for strings, and changes rng generators' API.
Because they are breaking changes, it means, we can't have clean CI in this repository, instead I've tested a full xenserver build with the changes. No issues were found (SR 218740)
matching xapi branch is at xapi-project/xen-api@master...psafont:xen-api:private/paus/stringy-crypto
Bengang is planning on doing a release on Friday, will open both PRs then.