Adapt code to new mirage-crypto (CP-308222) #6512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately mirage-crypto has accumulated breaking changes: - Cstructs have been replaced with strings - The digestif library has replaced ad-hoc hash implementation A deprecation has happened as well: - RNG initialization has changed Signed-off-by: Pau Ruiz Safont <[email protected]>
last-genius
approved these changes
Jun 9, 2025
lindig
approved these changes
Jun 9, 2025
The only use of it was a parameter that was not used anywhere Signed-off-by: Pau Ruiz Safont <[email protected]>
psafont
force-pushed
the
private/paus/stringy-crypto
branch
from
e356082 to
87ca449
Compare
Merged
via the queue into
xapi-project:master
with commit Jun 10, 2025
909b48e
16 of 18 checks passed
This was referenced Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately mirage-crypto has accumulated breaking changes:
A deprecation has happened as well:
Because there are breaking changes, xs-opam changes need to be introduced at the same time: xapi-project/xs-opam#731
Only xapi is affected by the breaking builds, so no other toolstack repositories have incoming PRs.
I've tested builds with Smoke and validation tests: SR 218740
This means that the merge will be done as such:
After merging both xenserver's CI should create a successful build with both PR included