fix: audit list window covered by tooltip and highlight #13373
+24
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8dbd586 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
jpwienekus
commented
Mar 6, 2025
| @@ -83,7 +83,7 @@ export class DevToolbarAuditListWindow extends HTMLElement { | |||
| "Noto Color Emoji"; | |||
| color: rgba(191, 193, 201, 1); | |||
| position: fixed; | |||
| z-index: 999999999; | |||
| z-index: 2000000009; | |||
There was a problem hiding this comment.
Highlights have a z-index of 2000000000, tooltips have a z-index of 2000000001
Updated the z-index here to 2000000009 for rare cases where the audit list window is rendered in the same space as the dev toolbar, which has a z-index of 2000000010
I suspect the visibility of the dev toolbar would be higher than the audit list window.
CodSpeed Performance ReportMerging #13373 will not alter performanceComparing Summary
|
jpwienekus
force-pushed
the
fix-audit-log-covered
branch
2 times, most recently
from
f4eb754 to
a6c9822
Compare
jpwienekus
force-pushed
the
fix-audit-log-covered
branch
2 times, most recently
from
a063190 to
48ffd4a
Compare
jpwienekus
force-pushed
the
fix-audit-log-covered
branch
from
a24fb15 to
8dbd586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes pop-ups and highlights rendering over the audit list window.
Fixes #11114
Testing
Added e2e test.
Docs