fix: Inherit PHP settings from the main process

src/Input/ChildCommandFactory.php

@@ -28,7 +28,7 @@
 final class ChildCommandFactory
 {
     public function __construct(
-        private readonly string $phpExecutable,
+        public readonly string $phpExecutable,
         private readonly string $scriptPath,
         private readonly string $commandName,
         private readonly InputDefinition $commandDefinition,
@@ -51,7 +51,6 @@ private function createBaseCommand(
         InputInterface $input
     ): array {
         return array_filter([
-            ...$this->getEscapedPhpExecutable(),
             $this->scriptPath,
             $this->commandName,
             ...array_map(strval(...), self::getArguments($input)),
@@ -74,14 +73,6 @@ private function getForwardedOptions(InputInterface $input): array
         );
     }
 
-    /**
-     * @return list<string>
-     */
-    private function getEscapedPhpExecutable(): array
-    {
-        return explode(' ', $this->phpExecutable);
-    }
-
     /**
      * @return list<string|bool|int|float|null|array<string|bool|int|float|null>>
      */

src/ParallelExecutor.php

@@ -266,6 +266,7 @@ private function createProcessLauncher(
         Logger $logger
     ): ProcessLauncher {
         return $this->processLauncherFactory->create(
+            $this->childCommandFactory->phpExecutable,
             $this->childCommandFactory->createChildCommand($input),
             $this->workingDirectory,
             $this->extraEnvironmentVariables,

src/Process/ProcessLauncherFactory.php

@@ -31,6 +31,7 @@ interface ProcessLauncherFactory
      * @param callable(): void           $tick
      */
     public function create(
+        string $phpExecutable,
         array $command,
         string $workingDirectory,
         ?array $extraEnvironmentVariables,

src/Process/StandardSymfonyProcessFactory.php

@@ -14,11 +14,12 @@
 namespace Webmozarts\Console\Parallelization\Process;
 
 use Symfony\Component\Process\InputStream;
+use Symfony\Component\Process\PhpSubprocess;
 use Symfony\Component\Process\Process;
 
 final class StandardSymfonyProcessFactory implements SymfonyProcessFactory
 {
     public function startProcess(
         int $index,
         InputStream $inputStream,
         array $command,
@@ -26,12 +27,10 @@
         ?array $environmentVariables,
         callable $processOutput
     ): Process {
-        $process = new Process(
+        $process = new PhpSubprocess(
             $command,
             $workingDirectory,
             $environmentVariables,
-            null,
-            null,
         );
 
         $process->setInput($inputStream);

src/Process/SymfonyProcessFactory.php

@@ -35,6 +35,7 @@ interface SymfonyProcessFactory
     public function startProcess(
         int $index,
         InputStream $inputStream,
+        string $phpExecutable,
         array $command,
         string $workingDirectory,
         ?array $environmentVariables,

src/Process/SymfonyProcessLauncher.php

@@ -60,6 +60,7 @@ final class SymfonyProcessLauncher implements ProcessLauncher
      * @param callable(): void           $tick
      */
     public function __construct(
+        private readonly string $phpExecutable,
         private readonly array $command,
         private readonly string $workingDirectory,
         private readonly ?array $environmentVariables,
@@ -135,6 +136,7 @@ private function startProcess(InputStream $inputStream): void
         $process = $this->processFactory->startProcess(
             $index,
             $inputStream,
+            $this->phpExecutable,
             $this->command,
             $this->workingDirectory,
             $this->environmentVariables,

src/Process/SymfonyProcessLauncherFactory.php

@@ -32,6 +32,7 @@ public function __construct(private readonly SymfonyProcessFactory $processFacto
      * @param callable(): void                                         $tick
      */
     public function create(
+        string $phpExecutable,
         array $command,
         string $workingDirectory,
         ?array $extraEnvironmentVariables,
@@ -42,6 +43,7 @@ public function create(
         callable $tick
     ): ProcessLauncher {
         return new SymfonyProcessLauncher(
+            $phpExecutable,
             $command,
             $workingDirectory,
             $extraEnvironmentVariables,

tests/Fixtures/Command/PhpSettingsCommand.php

@@ -0,0 +1,107 @@
+<?php
+
+/*
+ * This file is part of the Webmozarts Console Parallelization package.
+ *
+ * (c) Webmozarts GmbH <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Webmozarts\Console\Parallelization\Fixtures\Command;
+
+use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Input\InputDefinition;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Terminal;
+use Symfony\Component\Filesystem\Filesystem;
+use Webmozarts\Console\Parallelization\ErrorHandler\ErrorHandler;
+use Webmozarts\Console\Parallelization\Input\ParallelizationInput;
+use Webmozarts\Console\Parallelization\Integration\TestDebugProgressBarFactory;
+use Webmozarts\Console\Parallelization\Integration\TestLogger;
+use Webmozarts\Console\Parallelization\Logger\Logger;
+use Webmozarts\Console\Parallelization\Logger\NullLogger;
+use Webmozarts\Console\Parallelization\Logger\StandardLogger;
+use Webmozarts\Console\Parallelization\ParallelExecutorFactory;
+use Webmozarts\Console\Parallelization\Parallelization;
+use function file_get_contents;
+use function ini_get;
+use function json_decode;
+use function realpath;
+use const JSON_THROW_ON_ERROR;
+
+final class PhpSettingsCommand extends Command
+{
+    use Parallelization;
+
+    public const OUTPUT_DIR = __DIR__.'/../../../dist/php-settings';
+
+    public function __construct(
+        private Filesystem $filesystem,
+    ) {
+        parent::__construct('test:php-settings');
+    }
+
+    protected function configure(): void
+    {
+        ParallelizationInput::configureCommand($this);
+    }
+
+    /**
+     * @return list<string>
+     */
+    protected function fetchItems(InputInterface $input, OutputInterface $output): array
+    {
+        return ['item0'];
+    }
+
+    protected function getParallelExecutableFactory(
+        callable $fetchItems,
+        callable $runSingleCommand,
+        callable $getItemName,
+        string $commandName,
+        InputDefinition $commandDefinition,
+        ErrorHandler $errorHandler
+    ): ParallelExecutorFactory {
+        return ParallelExecutorFactory::create(
+            $fetchItems,
+            $runSingleCommand,
+            $getItemName,
+            $commandName,
+            $commandDefinition,
+            $errorHandler,
+        )
+            ->withRunBeforeFirstCommand(self::runBeforeFirstCommand(...))
+            ->withScriptPath(realpath(__DIR__.'/../../../bin/console'));
+    }
+
+    private function runBeforeFirstCommand(): void
+    {
+        $this->filesystem->dumpFile(
+            self::OUTPUT_DIR.'_main_process',
+            ini_get('memory_limit'),
+        );
+    }
+
+    protected function runSingleCommand(string $item, InputInterface $input, OutputInterface $output): void
+    {
+        $this->filesystem->dumpFile(
+            self::OUTPUT_DIR,
+            ini_get('memory_limit'),
+        );
+    }
+
+    protected function getItemName(?int $count): string
+    {
+        return 1 === $count ? 'item' : 'items';
+    }
+
+    protected function createLogger(InputInterface $input, OutputInterface $output): Logger
+    {
+        return new NullLogger();
+    }
+}

tests/Integration/PhpProcessSettingsTest.php

@@ -0,0 +1,68 @@
+<?php
+
+/*
+ * This file is part of the Webmozarts Console Parallelization package.
+ *
+ * (c) Webmozarts GmbH <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Webmozarts\Console\Parallelization\Integration;
+
+use PHPUnit\Framework\Attributes\CoversNothing;
+use PHPUnit\Framework\TestCase;
+use Symfony\Bundle\FrameworkBundle\Console\Application;
+use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Tester\CommandTester;
+use Symfony\Component\Process\Process;
+use Webmozarts\Console\Parallelization\Fixtures\Command\ImportMoviesCommand;
+use Webmozarts\Console\Parallelization\Fixtures\Command\ImportUnknownMoviesCountCommand;
+use Webmozarts\Console\Parallelization\Fixtures\Command\LegacyCommand;
+use Webmozarts\Console\Parallelization\Fixtures\Command\NoSubProcessCommand;
+use Webmozarts\Console\Parallelization\Fixtures\Command\PhpSettingsCommand;
+use Webmozarts\Console\Parallelization\Integration\BareKernel;
+use Webmozarts\Console\Parallelization\Integration\OutputNormalizer;
+use Webmozarts\Console\Parallelization\Integration\TestLogger;
+use function array_column;
+use function array_map;
+use function file_get_contents;
+use function preg_replace;
+use function spl_object_id;
+use function str_replace;
+
+/**
+ * @internal
+ */
+#[CoversNothing]
+class PhpProcessSettingsTest extends TestCase
+{
+    public function test_it_can_run_the_command_without_sub_processes(): void
+    {
+        $commandProcess = Process::fromShellCommandline(
+            'php -dmemory_limit="256M" bin/console test:php-settings',
+            __DIR__.'/../..',
+        );
+        $commandProcess->run();
+
+        $expectedMainProcessMemoryLimit = '256M';
+        $actualMainProcessMemoryLimit = file_get_contents(PhpSettingsCommand::OUTPUT_DIR.'_main_process');
+
+        $expectedChildProcessMemoryLimit = '256M';
+        $actualChildProcessMemoryLimit = file_get_contents(PhpSettingsCommand::OUTPUT_DIR);
+
+        self::assertSame(
+            [
+                $expectedMainProcessMemoryLimit,
+                $expectedChildProcessMemoryLimit,
+            ],
+            [
+                $actualMainProcessMemoryLimit,
+                $actualChildProcessMemoryLimit,
+            ],
+        );
+    }
+}