fix: Inherit PHP settings from the main process #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
theofidry
commented
Mar 23, 2025
•
theofidry
commented
- Review the changes
- Double check the PHPDoc
- Document the BC breaks in the Upgrade.md file
theofidry
commented
Mar 23, 2025
src/Input/ChildCommandFactory.php
Outdated
| @@ -28,7 +28,7 @@ | |||
| final class ChildCommandFactory | |||
| { | |||
| public function __construct( | |||
| private readonly string $phpExecutable, | |||
| public readonly string $phpExecutable, | |||
There was a problem hiding this comment.
To be able to pass the PHP executable to PhpSubprocess we need to expose it, instead of passing it as part of the created command
|
This will require several BC breaks hence scheduled for 3.0 |
theofidry
commented
Apr 20, 2025
| @@ -31,6 +31,7 @@ interface ProcessLauncherFactory | |||
| * @param callable(): void $tick | |||
| */ | |||
| public function create( | |||
| array $phpExecutable, | |||
There was a problem hiding this comment.
this change is a BC break
theofidry
commented
Apr 20, 2025
| @@ -35,6 +35,7 @@ interface SymfonyProcessFactory | |||
| public function startProcess( | |||
| int $index, | |||
| InputStream $inputStream, | |||
| array $phpExecutable, | |||
There was a problem hiding this comment.
this change is a BC break
theofidry
commented
Apr 20, 2025
| @@ -135,6 +136,7 @@ private function startProcess(InputStream $inputStream): void | |||
| $process = $this->processFactory->startProcess( | |||
| $index, | |||
| $inputStream, | |||
| $this->phpExecutable, | |||
There was a problem hiding this comment.
this change is a BC break
theofidry
commented
Apr 20, 2025
| @@ -32,6 +32,7 @@ public function __construct(private SymfonyProcessFactory $processFactory) | |||
| * @param callable(): void $tick | |||
| */ | |||
| public function create( | |||
| array $phpExecutable, | |||
There was a problem hiding this comment.
this change is a BC break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.