Skip to content
This repository was archived by the owner on Sep 20, 2019. It is now read-only.

generated es5-loader #740

Closed
wants to merge 4 commits into from
Closed

generated es5-loader #740

wants to merge 4 commits into from

Conversation

valdrinkoshi
Copy link
Contributor

@valdrinkoshi valdrinkoshi commented Mar 21, 2017

Fixes #737 by generating webcomponents-es5-loader.js out of the custom elements native shim + webcomponents-loader.
This allows browsers that implement customElements (e.g. chrome, STP) to use es5 style js to define custom elements.
The gambit is: only the native-shim is needed synchronously when the script is executed. We bundle it into the loader for this reason.
This requires users to NOT compile webcomponents-es5-loader.js ⚠️

Here's an example of it working as expected http://jsbin.com/babifij/2/edit?html,console,output

Fixes #722 by renaming webcomponents-loader to webcomponents-es6-loader

@dfreedm
Copy link
Contributor

dfreedm commented Mar 21, 2017

I like this approach. Let's also try #722 out in this PR.

@dfreedm dfreedm self-assigned this Mar 21, 2017
@valdrinkoshi
Copy link
Contributor Author

valdrinkoshi commented Mar 21, 2017

@azakus ready for review! Firefox 52 timed out for some reason (can't repro locally), so I've kicked the build again https://travis-ci.org/webcomponents/webcomponentsjs/builds/213528757

Update: yay the build is green 💚

@dfreedm
Copy link
Contributor

dfreedm commented Mar 21, 2017

Closing in favor of #741

@dfreedm dfreedm closed this Mar 21, 2017
@valdrinkoshi valdrinkoshi deleted the es5-loader branch April 7, 2017 22:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants