Skip to content
This repository was archived by the owner on Sep 20, 2019. It is now read-only.

Rename webcomponents-es5-loader to webcomponents-es5-transpiled-loader #722

Closed
dfreedm opened this issue Mar 11, 2017 · 4 comments
Closed
Assignees

Comments

@dfreedm
Copy link
Contributor

dfreedm commented Mar 11, 2017

The name is a bit confusing, as people do not need to use the es5 loader unless they have transpiled code.

@justinfagnani
Copy link
Contributor

That's a long name...

Maybe we can make things more clear by renaming the other loader to webcomponents-es6-loader?

Then we can say:

Deployed Code Loader Supported Browsers
ES5 webcomponents-es5-loader.js All
ES6 webcomponents-es6-loader.js Latest Chrome, Safari, FF, Edge
ES5* webcomponents-es6-loader.js IE, Older Safari, etc
  • You can do this if you're using differential serving to serve ES6 to the latest browsers and ES5 to older browser.

I like this because the only non-completely-straightforward case is the third row, which we could normally just omit, and is the advanced case.

@dfreedm dfreedm self-assigned this Mar 12, 2017
@CaptainCodeman
Copy link

Yeah, please have es5 and es6 for consistency ... it makes things neater and easier to set a single value and then use it in the URL for the polyfill and as the folder for built files (just experimenting with detecting the version to use on the browser so Chrome etc... can use the es6 versions while still serving es5 to older browsers - seems to work OK!)

@dfreedm
Copy link
Contributor Author

dfreedm commented Mar 21, 2017

As I was saying in #737 (comment), I think the better approach is to only have one loader, and require the user to put native-shim just before the loader if they compile.
It feels simpler to explain that way.

@dfreedm
Copy link
Contributor Author

dfreedm commented Mar 22, 2017

Closing in favor of #741

@dfreedm dfreedm closed this as completed Mar 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants