Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #749. Add a "My Activity" page. #801

Merged
merged 47 commits into from
Nov 3, 2015
Merged

Fixes #749. Add a "My Activity" page. #801

merged 47 commits into from
Nov 3, 2015

Conversation

miketaylr
Copy link
Member

And refactor a bunch of stuff to make it work.

Note there's more work to be done to make our components composiable/modular. This is a fest step towards making that happen with pagination. I'll likely re-do some of what I've done here with this Mixin pattern when we add sorting/per page dropdowns. But it works, so let's put it up for review.

r? @karlcow for Python/HTML/CSS bits
r? @hallvors for JS/HTML/CSS bits

And anybody who has feedback on visual design is welcome to provide that. I'll push to http://staging.webcompat.com/me

@miketaylr
Copy link
Member Author

Tests are failing, so it's possible I screwed up the merge conflicts. Let me push some fixup commits.

@miketaylr
Copy link
Member Author

Alright, tests are green. Fire ze (review) missles. 🚀

@magsout
Copy link
Member

magsout commented Oct 27, 2015

👍🎉💕

@magsout
Copy link
Member

magsout commented Oct 27, 2015

@miketaylr an error on staging:

capture d ecran 2015-10-27 a 19 43 25

@miketaylr
Copy link
Member Author

Hmm, thanks. Will look at it.

@miketaylr
Copy link
Member Author

(silly mistake)

('needsContact', 'needscontact', 'Needs Contact'),
('ready', 'contactready', 'Ready for Outreach'),
('sitewait', 'sitewait', 'Site Contacted'),
('close', 'closed', 'Closed')]

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

@miketaylr
Copy link
Member Author

(I just rebased against master and force pushed).

@miketaylr
Copy link
Member Author

One last failure, related to the fixture file labels.6665c4820456e6a813dcbbdddd690ffc.json being missing. Will take a look tonight or tomorrow, my brain is too jet lagged right now 😕

@miketaylr
Copy link
Member Author

Ah, now I get it. I rebased and master has the ?per_page=100 hack for the labels endpoint. Fixture files want a hashed encoding of GET params (to be able to serve different states). Let me see if renaming the file doesn't fix it.

@miketaylr
Copy link
Member Author

OK, it seems like everyone is on board with these changes, and tests are passing. I'm gonna go ahead and merge this now. We can clean up the few issues noted here when we iterate on the activity page and add in the other components as mixins.

miketaylr pushed a commit that referenced this pull request Nov 3, 2015
 Fixes #749. Add a "My Activity" page.
@miketaylr miketaylr merged commit 63c38f1 into master Nov 3, 2015
@miketaylr miketaylr deleted the issues/749/2 branch November 3, 2015 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants