-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #749. Add a "My Activity" page. #801
Conversation
Tests are failing, so it's possible I screwed up the merge conflicts. Let me push some fixup commits. |
810efed
to
79c6327
Compare
Alright, tests are green. Fire ze (review) missles. 🚀 |
👍🎉💕 |
@miketaylr an error on staging: |
Hmm, thanks. Will look at it. |
(silly mistake) |
('needsContact', 'needscontact', 'Needs Contact'), | ||
('ready', 'contactready', 'Ready for Outreach'), | ||
('sitewait', 'sitewait', 'Site Contacted'), | ||
('close', 'closed', 'Closed')] |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
8ad9818
to
2b76538
Compare
(I just rebased against master and force pushed). |
One last failure, related to the fixture file |
Ah, now I get it. I rebased and master has the |
OK, it seems like everyone is on board with these changes, and tests are passing. I'm gonna go ahead and merge this now. We can clean up the few issues noted here when we iterate on the activity page and add in the other components as mixins. |
Fixes #749. Add a "My Activity" page.
And refactor a bunch of stuff to make it work.
Note there's more work to be done to make our components composiable/modular. This is a fest step towards making that happen with pagination. I'll likely re-do some of what I've done here with this Mixin pattern when we add sorting/per page dropdowns. But it works, so let's put it up for review.
r? @karlcow for Python/HTML/CSS bits
r? @hallvors for JS/HTML/CSS bits
And anybody who has feedback on visual design is welcome to provide that. I'll push to http://staging.webcompat.com/me