Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a "My Activity" page #749

Closed
miketaylr opened this issue Oct 5, 2015 · 60 comments
Closed

Make a "My Activity" page #749

miketaylr opened this issue Oct 5, 2015 · 60 comments
Assignees

Comments

@miketaylr
Copy link
Member

From #442.

This issue is more specific. We want a page that shows:

  1. Bugs that @mention you
  2. Bugs that you reported.
@miketaylr
Copy link
Member Author

@karlcow I forget what we decided exactly for this.

"My Activity" is going to link to /me which redirects to /miketaylr (in my case)? Is that correct?

@miketaylr
Copy link
Member Author

  • Make API endpoints for "mentions" and "reported"
  • Make /me route in views.py that redirects to /<username>
  • Write Backbone views
  • Some kinda tests

@magsout
Copy link
Member

magsout commented Oct 5, 2015

"My Activity" is going to link to /me which redirects to /miketaylr (in my case)? Is that correct?

@miketaylr yes, correct 👍

@miketaylr
Copy link
Member Author

Thanks!

@miketaylr
Copy link
Member Author

I think we should probably add pagination for each section, and only display maybe 5 or 10 issues for mentions/reported issues.

@miketaylr
Copy link
Member Author

@magsout can you help with the headings? I just stole the markup from the browse-issues.html template, and it looks a little bogus. :p

This is in the issues/749/1 branch.

magsout added a commit that referenced this issue Oct 6, 2015
magsout added a commit that referenced this issue Oct 6, 2015
magsout added a commit that referenced this issue Oct 6, 2015
@magsout
Copy link
Member

magsout commented Oct 6, 2015

@miketaylr I cleaned the markup and codebase..

@magsout
Copy link
Member

magsout commented Oct 6, 2015

It's just a begining

@miketaylr
Copy link
Member Author

You're the best, @magsout.

@miketaylr
Copy link
Member Author

A few things to tweak:
This seems like it cuts off suddenly. Maybe a little bottom margin on the last issue item?

And here it looks a little unbalanced. Maybe we can split the bottom margin/padding of "miketaylr's activity" and the top margin/padding of "Issues reported by miketaylr"?

@magsout
Copy link
Member

magsout commented Oct 6, 2015

@miketaylr you renamed mentionned-user.html, but not in user-activity.html , right ?? I had an error when I pulled

@miketaylr
Copy link
Member Author

Ugh, yes. Sorry about that. I can get to it in about an hour or so, orrrrr you can fix it now. ^_^

@magsout
Copy link
Member

magsout commented Oct 6, 2015

@miketaylr

capture d ecran 2015-10-06 a 20 18 25
capture d ecran 2015-10-06 a 20 18 51

Seems different from you. I had some news utils class. Did you build css ? Or maybe some cache ?

miketaylr pushed a commit that referenced this issue Nov 3, 2015
magsout added a commit that referenced this issue Nov 3, 2015
miketaylr pushed a commit that referenced this issue Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants