Accessibility Fixes #363
Accessibility Fixes #363
Conversation
A bunch of accessibility fixes. Will need someone to double check and to fix styling as there were instances where I had to change headings (from H2 to H1 etc.) so they probably don't have the right styles anymore.
|
Awesome first pull request 🏃 Thanks. @andrewmcgivery In the next commits add the issue number you are working on. It will automatically notify for you the correct issue. And then we need to assign someone for the review. I wonder if @patrickhlauke would be interested ;). |
| @@ -2,7 +2,7 @@ | |||
| {% block body %} | |||
| <div class="page page--about about"> | |||
| {% include "shared/nav.html" %} | |||
| <div class="wc-content wc-content--body"> | |||
| <main class="wc-content wc-content--body" role="main"> | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Thanks a lot @andrewmcgivery . If you can use spaces instead of tab, please. If you can rebase from master because you have conflict on thanks.html page (button facebook and twitter) |
|
Regarding Internet Explorer support for |
|
@tagawa yes, you're right, actually Webcompat isn't compatible with ie8, so for ie9 >, we just need to add |
|
👍 with the rebase and spaces tweak.
Yeah... sorry about that. If you have suggestions or hints on how you got set up for Windows we would love to add those to CONTRIBUTING.md. 🍰 |
|
dev environment setup on windows is a pain. i recently followed this guide (to finally get my Bootstrap test env sorted) http://jekyll-windows.juthilo.com/ - wonder if there's good stuff to cherry-pick out of that? |
|
Nice one, thanks @patrickhlauke. I left a link in #364. |
|
@andrewmcgivery I can also resolve the conflict for you on your branch and push it to this PR if that's easier for you. Your call. |
|
@karlcow Sorry about the issue number thing! GitHub and I are in the early stages of getting to know each other. :) @magsout Regarding spaces, sorry about that! Should have paid more attention to that. :) @magsout @tagawa Thanks for looking into the stuff. Where specifically should that rule be added in?@miketaylr @patrickhlauke I never really got the windows stuff fully set up. I got stuck mostly around the Python stuff. Couldn't get the vritual enviroment stuff to install and setup properly. I believe I got Python and Pip installed, but even the Pip commands wouldn't work in command prompt.... tried to set up the Python folder where pip lives as a path, but still no luck. @miketaylr I'm going to take a look and see if I can resolve the conflict as a learning experience. May need assistance though. :) |
Conflicts: webcompat/templates/thanks.html
|
Should be good to go now I believe other than adding the CSS rule. When I get direction of where to add it, I can add it in and push another commit. :) |
Missed One.
|
Merge conflict resolved. Looks good! |
|
@miketaylr One thing I forgot to mention is that there is more stuff I would like to fix, but again would require some markup and CSS changes, so I figured I would file separate issues and merge requests for those. This pull request is a good first step forward though. |
|
@andrewmcgivery Absolutely. Smaller PRs/commits/issues are totally welcome. |
|
For |
|
Thanks a lot @andrewmcgivery for you job. HTML and CSS look good. I just need to polish contributors (size of title) page and title of issue-list (size of title) so I ll open a new issue |
|
Cool, thanks @tagawa and @andrewmcgivery. Since these changes mess with the style I'm going to merge this PR into the "staging" branch where @magsout can go in and tweak things back to normal. We'll then merge those into master. (Assuming I don't muck it all up, which is what I usually do). |
|
I've deployed to staging and rebased against the latest master (were a few conflicts to fix with some CSS refactoring going on at the same time). Visually the main things I see that need tweaking before we can deploy to master/production:
|
|
Guessing by the password prompt that one needs special permissions to see the staging server. :) Glad to see this pull request going forward! Excited to see my contributions going in! :) |
|
@andrewmcgivery yeah not really for security reasons. Just to keep people from accidentally filing bugs in the wrong place (happened in the past). If you'd like the username/pw shoot me an email at [email protected] and I'll give it to you. :) |
|
|
Just realized that the about page never got the headings fixed so that will have to be addressed in another issue/pull request. the Contributors page also has some outstanding heading issues that will need to be addressed. However, overall this is a big jump. From the pages I've run the checker on, this update will leave the site with 0 errors. There are still some outstanding warnings, but I will address those in further pull requests. |
…into tagawa-js-features * 'js-features' of https://github.com/tagawa/webcompat.com: Enabled 'g' key to open GitHub issues page Enabled 'g' key to open GitHub issues page Issue #363 - Fix tests to account for now markup. Issue #390 - Make Issues page title smaller Issue #390 - Issue title too big. Another Tab -> Space Accessibility Fixes
|
Took a little bit longer than expected--but this is on master now (it got merged in with some of @tagawa's fixes because I merged things in the wrong order) 🎈 Thanks @andrewmcgivery! I'll tag a release and deploy to the production site in a few hours. |
|
OK, now we're live. Again big ❤️ to @andrewmcgivery for the patches. |
|
Yes, thanks @andrewmcgivery - we needed this. |
|
Awesome, very good job @andrewmcgivery |
|
Thanks guys! :) This was a great step in the right direction. I'll start planning for the next batch of fixes! :) |
A bunch of accessibility fixes. Will need someone to double check and to
fix styling as there were instances where I had to change headings (from
H2 to H1 etc.) so they probably don't have the right styles anymore.
I had loads of trouble getting the environment set up on windows for local testing. >_<