Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Add roles and missing attributes on the markup #334

Closed
magsout opened this issue Nov 5, 2014 · 6 comments
Closed

[Accessibility] Add roles and missing attributes on the markup #334

magsout opened this issue Nov 5, 2014 · 6 comments

Comments

@magsout
Copy link
Member

magsout commented Nov 5, 2014

I think in the first time we can add the roles (banner, aside, etc ..) and basic attributes of the elements, we have forgotten (like type = "button")(such as type = "button")

@karlcow karlcow changed the title Better accessibility [Accessibility] Add roles and missing attributes on the markup Nov 6, 2014
@karlcow
Copy link
Member

karlcow commented Nov 6, 2014

Thanks @magsout for starting this. 🏆

Rephrased a bit the title. If it's too wide. I would encourage to reduce the scope. And create more issues for things to fix. :) It will hopefully help to attract someone who's willing to do a first-patch :)

@andrewmcgivery
Copy link
Contributor

Taking a look at this. Probably going to need a few pull requests for this. Bunch of small issues. :)

@andrewmcgivery
Copy link
Contributor

See pull request: #363

@miketaylr
Copy link
Member

Awesome!

@calexity calexity modified the milestone: Fix design debt Dec 4, 2014
@andrewmcgivery
Copy link
Contributor

This can probably be closed now.

@karlcow
Copy link
Member

karlcow commented Dec 15, 2014

according to @andrewmcgivery, let's close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants