Fixes #3464 - Only reject an issue for action==closed

[miketaylr]

Without this fix, it's possible to reject a previously closed issue, which is not what we want.

[miketaylr]

Thinking of how to add a test for this.

[miketaylr]

r? @karlcow

(Note: i've tested this on staging, the latest version of this branch is deployed there if you'd also like to test)

[karlcow]

@miketaylr Thanks for the fix.

Could we give better comments for each of the if in process issues actions.
Where we clearly explain what we do.

Also in the initial design, we were making sure that we could not by mistakes publish something which was rejected. Is it still the case?

• closing meant rejected
• milestone meant accepted.

[karlcow]

Also in the initial design, we were making sure that we could not by mistakes publish something which was rejected. Is it still the case?

Still the case. Cool.

webcompat.com/webcompat/webhooks/model.py

Lines 279 to 291 in c7b1fa5

	elif (scope == 'private' and self.action == 'closed' and
	self.milestone == 'unmoderated'):
	# private issue has been closed. It is rejected
	# We need to patch with a template.
	try:
	self.close_public_issue(reason='rejected')
	except HTTPError as e:
	msg_log('public rejection failed', self.number)
	return oops()
	else:
	# we didn't get exceptions, so it's safe to close it
	self.close_private_issue()
	return make_response('Moderated issue rejected', 200)

[miketaylr]

Thanks Karl. Will add some comments then merge.