New milestone moderation not working as expected (on staging)

[miketaylr]

I will investigate:

I filed 2 issues, here's one:

webcompat/webcompat-tests-private#201 -> closed as accepted:invalid
But the public issue was rejected: webcompat/webcompat-tests#2561

[miketaylr]

(regular rejection + accepted still works)

[miketaylr]

That's a lot of activity after changing the milestone of a single issue! (Maybe that's expected... GitHub sends a ton of events)

[miketaylr]

GitHub claims to only have sent 3, so maybe there's something there.

edit: nah, I just forgot the public repo also uses the same webhook.

We also seem to be in the right place when marking an issue as "accepted: incomplete"
,
Aug 21 17:03:07 staging-server webcompat-staging: attempting to close as incomplete

[miketaylr]

OK, looking at the webhook events from webcompat-tests (the public half), we see the following chain:

1. action: opened - issue gets filed, 200 response, expected
2. action: labeled - gets a action-needsmoderation label, 403 response, expected
3. action: edited - the title is getting changed from "In the moderation queue" to "example.com - site is not usable", 403 response, expected
4. action: demilestoned - i think this is going from "needstriage" to "incomplete". 403 response. 🚨Probably expected??
5. action: closed - 403 response, expected
6. action: edited - the body was changed from "This issue has been put in the moderation..." to "Thanks for the report. Unfortunately without any\ndetail about the issue you experienced", 403 response, expected (this is the "incomplete" body)
7. action: milestoned - first milestone has title of "invalid", second milestone has title of "invalid", 403 response, 🚨seems unexpected?? (how is this a change, and how is it happening?)
8. action: edited - title changed from ""from": "example.com - site is not usable" to ""Issue rejected.", 403 response, 🚨seems unexpected
9. action: demilestoned - from incomplete to invalid, 403 reponse, 🚨seems unexpected (rejected issues are invalid)
10. action: labeled - gets a "status-notacceptable" label, 403 response, 🚨unexpected (for an incomplete issue)
11. action: edited - the body is edited from the incomplete message to the rejected one ("the content of this issue doesn't meet...", 403 response, 🚨unexpected
12. action: unlabeled - "browser-fixme" is removed, 403 response, not sure if expected or what. not important right now.
13. action: unlabeled - "action-needsmoderation" is removed, 403 response, 🚨unexpected (for an incomplete issue)

[miketaylr]

Ah, I think I know what's up.

[miketaylr]

Somehow close_public_issue is getting called 3 times, with the first being what we want, then reason=rejected called twice more. Probably time to re-examine the process_issue_action logic.

[miketaylr]

This is probably the issue,

webcompat.com/webcompat/webhooks/model.py

Lines 279 to 284 in dc7f900

	elif (scope == 'private' and self.state == 'closed' and
	not self.milestone == 'accepted'):
	# private issue has been closed. It is rejected
	# We need to patch with a template.
	try:
	self.close_public_issue(reason='rejected')

I failed to consider that accepted: invalid is not accepted, so the issue gets rejected. And there's no action in this branch, so it can happen when we don't expect it to now.