Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3076 - Remove maxlength for textarea #3078

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Fixes #3076 - Remove maxlength for textarea #3078

merged 1 commit into from
Nov 7, 2019

Conversation

miketaylr
Copy link
Member

I have no idea why this was in there

I tested locally and filed https://staging.webcompat.com/issues/2155, seems to work just fine.

Issue #3076 - Remove maxlength for textarea
5f0a6b5 
I have no idea why this was in there
@miketaylr miketaylr changed the title Issue #3076 - Remove maxlength for textarea Fixes #3076 - Remove maxlength for textarea Nov 6, 2019
@miketaylr miketaylr requested a review from karlcow November 6, 2019 23:19
@karlcow
Copy link
Member

karlcow commented Nov 6, 2019

This was introduced here.
https://github.com/webcompat/webcompat.com/pull/2937/files#diff-e4d749fcccd2131889fbcaab5046ac88R238 in #2937

karlcow
karlcow approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect a design constraint, but this is not necessary indeed clever to limit the amount of information, without explaining why.

@karlcow karlcow merged commit 891ebc4 into master Nov 7, 2019
@karlcow karlcow deleted the issues/3076/1 branch November 7, 2019 00:07
@miketaylr
Copy link
Member Author

Thanks for linking to the history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlcow karlcow karlcow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miketaylr @karlcow