Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed #2268 - moved navbar handler #2896

Merged
merged 1 commit into from
Jun 21, 2019
Merged

fixed #2268 - moved navbar handler #2896

merged 1 commit into from
Jun 21, 2019

Conversation

magsout
Copy link
Member

@magsout magsout commented Jun 20, 2019

This PR fixes issue #2268

Proposed PR background

@magsout magsout requested a review from miketaylr June 20, 2019 23:35
@magsout magsout changed the title fixed #2268 - moved navbar function fixed #2268 - moved navbar handler Jun 20, 2019
miketaylr
miketaylr approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@miketaylr miketaylr merged commit 5e14037 into master Jun 21, 2019
@miketaylr miketaylr deleted the issues/2268 branch June 21, 2019 03:46
@karlcow karlcow mentioned this pull request Oct 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketaylr miketaylr miketaylr approved these changes

Assignees
No one assigned
Labels
lang: JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magsout @miketaylr @karlcow