Skip to content

Find better place for navbar scroll handler #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
miketaylr opened this issue Mar 20, 2018 · 0 comments
Closed

Find better place for navbar scroll handler #2268

miketaylr opened this issue Mar 20, 2018 · 0 comments
Assignees
@magsout
Labels
lang: JS prio: backlog status: discussion

Comments

@miketaylr
Copy link
Member

miketaylr commented Mar 20, 2018 •
edited
Loading

Right now it's in homepage.js (on the refactor branch, soon on master), which makes sense because it's included on every page.

What doesn't make sense is that hompage.js is included on every page. It would be nice to either separate this out now, or make everything modular and use fancy code-splitting. #1352 and related issues would help us here.
@miketaylr miketaylr mentioned this issue Mar 20, 2018
Merged
@Regaddi Regaddi mentioned this issue May 8, 2018
Merged
@miketaylr miketaylr modified the milestone: Paris October 2018 Sep 24, 2018
magsout added a commit that referenced this issue Jun 20, 2019
@magsout
Issue #2268 - moved navbar function
220d5c3
@magsout magsout mentioned this issue Jun 20, 2019
Merged
1 task
magsout added a commit that referenced this issue Jun 20, 2019
@magsout
Issue #2268 - moved navbar function
42d98ed
@karlcow karlcow mentioned this issue Oct 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magsout magsout

Labels
lang: JS prio: backlog status: discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@miketaylr @zoepage @magsout