Skip to content

test(go): refactor flaky auth test #4637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Jan 26, 2025

Closes

What changed?

Refactor a test that is flaky, at least on my workstation, to something more "bullet proof".

Why was this change made?

I was struggling with this when working on #4626. I tried to fix it in that PR, but the test still fails occasionally.

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@erikgb erikgb enabled auto-merge (rebase) January 26, 2025 17:38
@erikgb erikgb requested a review from casibbald January 26, 2025 17:38
@erikgb erikgb force-pushed the better-auth-test--fix branch from 9c3c43a to 461dd8f Compare January 27, 2025 20:09
@erikgb erikgb requested a review from a team January 28, 2025 07:11
@erikgb erikgb force-pushed the better-auth-test--fix branch from 461dd8f to b9b985d Compare January 28, 2025 08:03
@erikgb erikgb merged commit 221fd18 into weaveworks:main Jan 28, 2025
13 checks passed
This was referenced Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants