Skip to content

fix: add namespaces to helmchart #4598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

casibbald
Copy link
Collaborator

Closes

What changed?
Add namespaces to helm chart

Why was this change made?

To fully conform with helm chart spec

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@casibbald casibbald requested a review from a team January 22, 2025 11:49
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casibbald casibbald merged commit ec71a7d into weaveworks:main Jan 22, 2025
21 checks passed
@casibbald casibbald deleted the add_namespaces branch January 22, 2025 12:06
This was referenced Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants