Skip to content

fix: correct image automation git repository for podinfo #4538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

casibbald
Copy link
Collaborator

Closes

What changed?
Image automation refers to incorrect details

Why was this change made?
to correct image automation in the dev-resources

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@casibbald casibbald requested a review from mproffitt January 15, 2025 19:13
@casibbald casibbald enabled auto-merge (squash) January 15, 2025 19:14
@casibbald casibbald requested review from erikgb and kingdonb January 15, 2025 19:47
@erikgb
Copy link
Contributor

erikgb commented Jan 15, 2025

@casibbald This was done intentionally in #4511 (comment) by @mproffitt. I am ok to change this, but it could be useful to test error situation. Is this used by the new test workflow?

@casibbald
Copy link
Collaborator Author

casibbald commented Jan 15, 2025

So image automation is such an integral part of the solution, do we specifically need this as the failed resource?
Can we create a different failed resource? maybe a GitRepository that does not have the right token to pull?
Or we add a second application with the same kind of failure?

@casibbald
Copy link
Collaborator Author

https://github.com/weaveworks/weave-gitops/blob/main/playwright/apps/violating-app/deployment.yaml

In playwright, we will have another podinfo that has violations and other issues for testing. Which makes having the one above working correctly valuable.

erikgb
erikgb previously approved these changes Jan 15, 2025
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! LGTM

@casibbald casibbald force-pushed the fix-image-automation branch from 1adec5b to 6758d69 Compare January 16, 2025 07:17
@casibbald casibbald merged commit 18ee157 into weaveworks:main Jan 16, 2025
13 checks passed
@casibbald casibbald deleted the fix-image-automation branch January 16, 2025 07:47
This was referenced Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants