Skip to content

chore: remove unused useRequestState #4335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

tenstad
Copy link
Contributor

@tenstad tenstad commented Jan 1, 2025

What changed?

Removes useRequestState

Why was this change made?

It's not in use and causes issues in React 18 #4334 (rendering error in return <div data-testid={id}>{error}</div>;, as it's not a ReactNode).

We can alternatively do a small workaround instead of removing it completely:
image

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@tenstad tenstad force-pushed the rm-use-request-state branch from a0f65e5 to 571f3a9 Compare January 1, 2025 13:34
@tenstad tenstad marked this pull request as ready for review January 1, 2025 13:38
@casibbald casibbald merged commit 53bfa67 into weaveworks:main Jan 1, 2025
17 checks passed
This was referenced Jan 15, 2025
This was referenced Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants