Skip to content

chore(deps): upgrade to react 18 and styled-components 6 #4334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 1, 2025

Conversation

tenstad
Copy link
Contributor

@tenstad tenstad commented Jan 1, 2025

https://react.dev/blog/2022/03/08/react-18-upgrade-guide

What changed?
Upgrades react to 18 and styled-components to 6

Now improved validation of props, so had to fix a few typing issues for both components and html-types

Why was this change made?

How was this change implemented?

How did you validate the change?

tilt up - check a few views

Release notes

Documentation Changes

@tenstad tenstad force-pushed the react-18 branch 6 times, most recently from c922451 to e3ce232 Compare January 1, 2025 13:24
@tenstad tenstad changed the title chore(deps): upgrade to react 18 chore(deps): upgrade to react 18 and styled-components 6 Jan 1, 2025
@tenstad tenstad force-pushed the react-18 branch 8 times, most recently from 5687b1f to 33471e4 Compare January 1, 2025 16:06
@tenstad tenstad marked this pull request as ready for review January 1, 2025 16:12
@tenstad tenstad requested a review from casibbald January 1, 2025 16:12
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casibbald casibbald merged commit ffd45c5 into weaveworks:main Jan 1, 2025
22 checks passed
This was referenced Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants