Fix error in "get a known shadow root" algorithm #1726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimboo
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Looks good to me. Thanks Sasha!
@sadym-chromium mind having a quick look as well? Thanks.
|
Small bug fix so we probably do not have to wait for further reviewers. I'm going ahead and merge this PR. Thanks @lutien. |
github-actions bot
added a commit
that referenced
this pull request
Mar 21, 2023
SHA: 231c5fb Reason: push, by whimboo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
The wdspec tests have already been updated and a test for that change can be found here. |
github-actions bot
added a commit
to xjc90s/webdriver
that referenced
this pull request
Mar 21, 2023
SHA: 231c5fb Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to soloinovator/webdriver
that referenced
this pull request
Mar 21, 2023
SHA: 231c5fb Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update error in get a known shadow root algorithm from no such element to no such shadow root.
Preview | Diff