-
Notifications
You must be signed in to change notification settings - Fork 23
Shadow Root support #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
PR has been submitted to support Shadow Root in the W3C specs. Will update _WD_GetShadowRoot once this gets finalized |
_WD_GetShadowRoot has been updated. Still needs to be implemented in geckodriver (https://bugzilla.mozilla.org/show_bug.cgi?id=1700095) |
Chromedriver implementation tracking -- https://bugs.chromium.org/p/chromedriver/issues/detail?id=3715 |
Latest revisions tested successfully with Chrome. Still waiting for Geckodriver to be updated. |
After it is updated, will it still be necessary to implement corrections in this respect to this UDF? Or are we just waiting to close this ISSUE to test whether the solution introduced into the UDF worked? |
I don't believe any further modifications are required, but I'm stating that without reviewing the existing code. |
From the Geckodriver 0.31.0 change log --
|
The given issue has been closed. How this relates on our work here ? |
@mlipok It doesn't change anything. Leaving this open until further testing is performed with the various webdrivers. |
_WD_GetShadowRoot seems to be working good on all browsers. Used this code for testing -- Func UserTesting() ; here you can replace the code to test your stuff before you ask on the forum
_WD_Navigate($sSession, "https://component.kitchen/elix/Tabs")
$sRoot = _WD_GetShadowRoot($sSession, $_WD_LOCATOR_ByXPath, "//elix-tabs[@id='sampleTabs']")
$sDiv = _WD_FindElement($sSession, $_WD_LOCATOR_ByCSSSelector, "#explorerContainer", $sRoot)
$sRoot2 = _WD_GetShadowRoot($sSession, $_WD_LOCATOR_ByCSSSelector, "#proxyList", $sDiv)
;~ Exit
EndFunc ;==>UserTesting |
It was game changer, as I see. |
Will check ASAP. |
Here is revised code for testing shadow root support in _WD_FindElement -- Func UserTesting() ; here you can replace the code to test your stuff before you ask on the forum
_WD_Navigate($sSession, "https://component.kitchen/elix/Tabs")
$sRoot = _WD_GetShadowRoot($sSession, $_WD_LOCATOR_ByXPath, "//elix-tabs[@id='sampleTabs']")
$sDiv = _WD_FindElement($sSession, $_WD_LOCATOR_ByCSSSelector, "#explorerContainer", $sRoot, Default, True)
$sRoot2 = _WD_GetShadowRoot($sSession, $_WD_LOCATOR_ByCSSSelector, "#proxyList", $sDiv)
;~ Exit
EndFunc ;==>UserTesting``` |
Firefox
Chrome
Edge
Opera
|
Firefox functionality still depends on bug 1700095 |
|
All looks fine (expect mentioned FF bug). Please consider adding this snippet to wd_demo.au3 as |
I'd prefer to leave this out of wd_demo for the following reasons --
The wiki may be a better option. |
So do you whether you intend to close this ticket or mark it as |
There are some changes in: Maybe soon will be fixed. Related: |
Is this related to our case ? |
Looks like this fix just landed for Firefox. Will need to confirm once v113 is released. |
Geckodriver has been updated. FF v113 is still a month from release, but it can be tested using the Nightly release. |
https://github.com/mozilla/geckodriver/releases/tag/v0.33.0 |
version 112 was released. |
Please also take a look here:
|
as to FF 113 (ships on [May 09, 2023])
|
Tested with FF113 --
|
https://bugzilla.mozilla.org/show_bug.cgi?id=1489490&GoAheadAndLogIn=1
The text was updated successfully, but these errors were encountered: