-
Notifications
You must be signed in to change notification settings - Fork 128
Tidying up section "Characteristics of Roles" #1733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Revisiting this, I think this is ready for review. This does not address one suggestion from #1263
Primarily, because it would add a lot of noise. Also, because we might consider doing this for all characteristics (not just "supported states and properties"). |
Rebased on main. |
<h4>Description Computation</h4> | ||
<p><a href="#mapping_additional_nd_description" class="accname">Description Computation</a> is defined in the Accessible Name and Description specification.</p> | ||
</section> | ||
<section id="textalternativecomputation"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#textalternativecomputation, #namecomputation and #descriptioncomputation are referenced from other places (maybe outside this document too - I don't know). Where should these references be updated to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where should these references be updated to?
ouch, another oversight. They could point to accname directly, no? If they need to be reproduce, we could move this to terms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fun fact: #mapping_additional_nd_te
(which I copy&pasted from the old version) also does not seem to match an ID at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#namecomputation
is not used in the document anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#descriptioncomputation
is not used in the document anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#mapping_additional_nd_description
also needs something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I fixed all relevant ones now. @jnurthen please take another look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jnurthen post TPAC ping.
#1263 mentions, in Problem 1, that the list values for the "Accessible Name Calculation" need to be kept. But they have been removed. |
I'm not sure I follow. They are under the h3 with "Name From" now. Sorry if I misunderstand what you're pointing out. |
I should wait until the question about #textalternativecomputation, #namecomputation and #descriptioncomputation is answered
@pkra please fix the conflicts and we can merge |
@jnurthen I'll need to do a fresh PR. There have been too many changes the relevant parts of the spec (as is probably expected after 3 years). |
Replaced by #2506 |
A first step.
Resolves #1263
Preview | Diff