Skip to content

Tidying up section "Characteristics of Roles" #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

pkra
Copy link
Member

@pkra pkra commented Apr 29, 2022

A first step.

Resolves #1263


Preview | Diff

@pkra pkra added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Apr 29, 2022
@pkra pkra added this to the ARIA 1.3 milestone Apr 29, 2022
@pkra pkra requested a review from jnurthen April 29, 2022 11:27
@pkra pkra self-assigned this May 10, 2022
@pkra
Copy link
Member Author

pkra commented Jun 21, 2022

Revisiting this, I think this is ready for review.

This does not address one suggestion from #1263

Consider also linking from the characteristics tables to the characteristic definitions. For example, "Supported States and Properties" in each table should link to the Supported States and Properties definition.

Primarily, because it would add a lot of noise. Also, because we might consider doing this for all characteristics (not just "supported states and properties").

@pkra
Copy link
Member Author

pkra commented Jun 24, 2022

Rebased on main.

<h4>Description Computation</h4>
<p><a href="#mapping_additional_nd_description" class="accname">Description Computation</a> is defined in the Accessible Name and Description specification.</p>
</section>
<section id="textalternativecomputation">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#textalternativecomputation, #namecomputation and #descriptioncomputation are referenced from other places (maybe outside this document too - I don't know). Where should these references be updated to?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where should these references be updated to?

ouch, another oversight. They could point to accname directly, no? If they need to be reproduce, we could move this to terms.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact: #mapping_additional_nd_te (which I copy&pasted from the old version) also does not seem to match an ID at this point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#namecomputation is not used in the document anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#descriptioncomputation is not used in the document anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#mapping_additional_nd_description also needs something.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I fixed all relevant ones now. @jnurthen please take another look?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnurthen post TPAC ping.

@chlane
Copy link
Contributor

chlane commented Jul 5, 2022

#1263 mentions, in Problem 1, that the list values for the "Accessible Name Calculation" need to be kept. But they have been removed.

@pkra
Copy link
Member Author

pkra commented Jul 6, 2022

#1263 mentions, in Problem 1, that the list values for the "Accessible Name Calculation" need to be kept. But they have been removed.

I'm not sure I follow. They are under the h3 with "Name From" now. Sorry if I misunderstand what you're pointing out.

chlane
chlane previously approved these changes Jul 6, 2022
@chlane chlane dismissed their stale review July 6, 2022 15:34

I should wait until the question about #textalternativecomputation, #namecomputation and #descriptioncomputation is answered

@spectranaut spectranaut removed the Agenda label Jul 7, 2022
@pkra pkra removed the question label Sep 7, 2022
@jnurthen jnurthen self-assigned this Jan 19, 2023
@pkra pkra added the spec:aria label Jun 14, 2024
@pkra pkra requested a review from jnurthen January 30, 2025 08:01
@jnurthen
Copy link
Member

jnurthen commented Apr 1, 2025

@pkra please fix the conflicts and we can merge

@pkra
Copy link
Member Author

pkra commented Apr 2, 2025

@jnurthen I'll need to do a fresh PR. There have been too many changes the relevant parts of the spec (as is probably expected after 3 years).

pkra added a commit that referenced this pull request Apr 2, 2025
@pkra
Copy link
Member Author

pkra commented Apr 2, 2025

Replaced by #2506

@pkra pkra closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo spec:aria
Projects
Status: pkra
Development

Successfully merging this pull request may close these issues.

Characteristics of Roles section needs tidying up
4 participants