Skip to content

refactor: streamline eslint config #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 27, 2025
Merged

refactor: streamline eslint config #24

merged 16 commits into from
Mar 27, 2025

Conversation

AndreyYolkin
Copy link
Contributor

@AndreyYolkin AndreyYolkin commented Mar 26, 2025

After this PR we will have latest versions of eslint and related dependencies.
Honorable mentions:

  1. Replace deprecated rules with one's provided by eslint.style. Deprecated rule no-return-await is removed

The original intent of this rule was to discourage the use of return await, to avoid an extra microtask. However, due to the fact that JavaScript now handles native Promises differently, there is no longer an extra microtask. More technical information can be found in this V8 blog entry.

  1. Adopt dogfooding and use the config in the repo itself
  2. Update readme to add pnpm and split installation instruction for easier copying
  3. Add indentation rule for non-vue files
  4. Remove unused eslint plugins

- Update ESLint and related dependencies to latest versions
- Replace deprecated `vueTsEslintConfig` with `defineConfigWithVueTs` and `vueTsConfigs`
- Migrate deprecated stylistic rules to `@stylistic` plugin
It seems to be good to adopt eslint to the repo itself
Add pnpm and reorganize yarn/npm commands for clarity and completeness
The `eslint-plugin-import`, `eslint-plugin-node`, and `eslint-plugin-promise` plugins were removed from the dependencies as they are no longer used in the project.
This commit adds the '@stylistic/indent' rule to enforce consistent indentation of 2 spaces, improving code readability and maintaining style consistency across the codebase.

fix: off indent rule inside vue files
chore: remove debug file from distribution
Move '@vue/eslint-config-typescript' from devDependencies to dependencies and add '@eslint/js' to dependencies. This ensures all necessary packages are available in production and aligns with the project's peerDependencies.
@AndreyYolkin AndreyYolkin merged commit 6020d45 into master Mar 27, 2025
@AndreyYolkin AndreyYolkin deleted the ae-update-deps branch April 19, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants