Skip to content

feat: refresh project dependencies #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Apr 10, 2025
Merged

feat: refresh project dependencies #66

merged 29 commits into from
Apr 10, 2025

Conversation

AndreyYolkin
Copy link
Contributor

@AndreyYolkin AndreyYolkin commented Mar 23, 2025

In this PR we have:

  1. Cleaned up dependencies list
  2. Updated project and templates dependencies
  3. Adopted eslint v9 with our config
  4. Migrated from discontinued vite-plugin-vue-layouts to vite-plugin-vue-layouts-next (see comment)

closes #65
related #54

this also changes `module` to esnext. We are using esbuild to build, so between modern flags `nodenext` and `bundler` we should pick `bundler`
This also has a small refactoring of the package name prompt to handle modern requirements
Latest node allows to use --run flag to launch scripts faster
…youts-next

The main goal is to get latest version of deps installed. This also comes with migrating to vite-plugin-vue-layouts-next from discontinued vite-plugin-vue-layouts. Eslint integration was also updated
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good. Only a few points of feedback.

@AndreyYolkin AndreyYolkin marked this pull request as draft March 26, 2025 22:41
@AndreyYolkin
Copy link
Contributor Author

AndreyYolkin commented Mar 26, 2025

Converting it to draft, I would like to merge #67 and use our refreshed eslint config first

Update the vuetify dependency in both TypeScript and JavaScript template package.json files to version 3.8.0 to ensure compatibility and leverage the latest features and improvements
@AndreyYolkin
Copy link
Contributor Author

Eslint config adopted, only wait for #67 to be finalised

@userquin
Copy link
Member

userquin commented Apr 4, 2025

argg, I must be blind, I didn't see this PR

@johnleider
Copy link
Member

Eslint config adopted, only wait for #67 to be finalised

I'll prioritize this.

@userquin
Copy link
Member

userquin commented Apr 4, 2025

Update sass-embedded dependency to ^1.86.3 across multiple templates, drop sass dependency and add preprocessorOptions for scss
@AndreyYolkin AndreyYolkin marked this pull request as ready for review April 4, 2025 21:42
@AndreyYolkin AndreyYolkin requested a review from johnleider April 7, 2025 20:58
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative approval. I have to run through all the variations still, but from a code perspective, everything seems to be in order.

To address modern pnpm policy (https://pnpm.io/cli/approve-builds) from poc was backported util to check ignored builds
Enable automatic imports for Pinia functions (defineStore, useStore, storeToRefs) in both JavaScript and TypeScript templates to simplify usage and reduce manual imports
Simplify auto-imports configuration by using recommended VueRouterAutoImports and removing non-existing Pinia imports.
@AndreyYolkin AndreyYolkin merged commit d3bb2aa into master Apr 10, 2025
1 check passed
@AndreyYolkin AndreyYolkin deleted the ae-refresh-cli branch April 25, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vite-plugin-vue-layouts not compatible anymore with vite 6.x <
3 participants