feat: make PluginContext available for Vite-specific hooks #19936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
the
p2-nice-to-have
patak-dev
previously approved these changes
Apr 25, 2025
|
I've resolved conflicts and added support for buildApp hook |
patak-dev
previously approved these changes
May 19, 2025
sapphi-red
deleted the
feat/make-plugin-context-available-in-vite-specific-hooks
branch
|
@sapphi-red linking related ecosystem CI results from here too: #20115 (comment) |
This was referenced May 29, 2025
dai-shi
pushed a commit
to wakujs/waku
that referenced
this pull request
May 29, 2025
While the current patch code works fine as `this` is `undefined` for current Vite, Vite 7+ will pass the context (vitejs/vite#19936) and the current code doesn't work anymore. This PR changes the code to call the hook function with the original `this`. This PR should fix the ecosystem-ci failure. https://github.com/vitejs/vite-ecosystem-ci/actions/runs/15291891294/job/43012757791#step:8:665
6 tasks
fwouts
pushed a commit
to fwouts/previewjs
that referenced
this pull request
Jun 3, 2025
While the current patch code works fine as `this` is `undefined` for current Vite, Vite 7+ will pass the context (vitejs/vite#19936) and the current code doesn't work anymore. This PR changes the code to call the hook function with the original `this`. This PR should fix the ecosystem-ci failure. https://github.com/vitejs/vite-ecosystem-ci/actions/runs/15291891294/job/43012757742#step:8:3335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make PluginContext available for Vite-specific hooks.
By making PluginContext available, we have the following upsides:
this.meta.viteVersion(feat: expose version at ConfigEnv #19355) can be implementedthis.meta.rolldownVersioncan be easily checkedthis.info,this.warn) can now be used more easilyEach hooks will receive the following plugin context types:
config:ConfigPluginContextconfigEnvironment:ConfigPluginContextconfigResolved:MinimalPluginContextWithoutEnvironmenthandleHotUpdate:MinimalPluginContextWithoutEnvironmenttransformIndexHtml:MinimalPluginContextWithoutEnvironmentconfigureServer:MinimalPluginContextWithoutEnvironmentconfigurePreviewServer:MinimalPluginContextWithoutEnvironmenthotUpdate:MinimalPluginContextWithoutEnvironmentbuildApp:MinimalPluginContextWithoutEnvironmenthandleHotUpdate:MinimalPluginContext & { environment: DevEnvironment }ConfigPluginContextdoes not have access tothis.meta.watchModeandthis.environment.MinimalPluginContextWithoutEnvironmentdoes not have access tothis.environment.