Skip to content

test: pass context to config hook for Vite 7 #7647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

sapphi-red
Copy link
Contributor

What is it?

  • Docs / tests / types / typos

Description

Vite 7+ will pass the context (vitejs/vite#19936) to config hook and the current test code does not pass it and a type error was happening.
This PR fixes that.

This PR should fix the ecosystem-ci failure.
https://github.com/vitejs/vite-ecosystem-ci/actions/runs/15291891294/job/43012757752#step:8:1008

Checklist

@sapphi-red sapphi-red requested a review from a team as a code owner May 29, 2025 09:29
Copy link

changeset-bot bot commented May 29, 2025

⚠️ No Changeset found

Latest commit: e26a5d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented May 29, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7647
npm i https://pkg.pr.new/@builder.io/qwik-city@7647
npm i https://pkg.pr.new/eslint-plugin-qwik@7647
npm i https://pkg.pr.new/create-qwik@7647

commit: e26a5d2

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @sapphi-red

@gioboa gioboa merged commit 2b24343 into QwikDev:main May 29, 2025
15 checks passed
@sapphi-red sapphi-red deleted the test/pass-context-to-config-hook branch May 29, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants