Implementation of data channels on top of webrtc data channels

[tdrz]

Implementation of #53

Not implemented:

• Tests for DataConsumer
• SendHandler::StopSendingData() and SendHandler::StopReceivingData() are only stubs - question is if they should be implemented
• DataChannel's priority

[ibc]

Thanks for this. We'll take a look when possible (unfortunately very busy lately).

[tdrz]

Thanks for this.

Thank you guys for a great system and implementation.

We'll take a look when possible (unfortunately very busy lately).

No worries, there's no rush from my side. I also have to switch to something else in the mean time (that's why some things are not completely implemented).

[jmillan]

It's looking good so far :-)

[tdrz]

Thanks, I will (hopefully) make the changes this week.

[jmillan]

Sure @copiltembel,

You can apply my cosmetic changes within github directly if that is more comfortable for you.

[tdrz]

mediasoup-broadcaster-demo: https://github.com/copiltembel/mediasoup-broadcaster-demo-datachannels - here I've added libmediasoup as a submodule, so if you checkout the code, make sure to do git clone ... and then git submodule init and git submodule update to fetch all the data.

Can you please make a PR to mediasoup-broadcaster-demo adding datachannels, so we just maintain 1 demo for this purposes?

Sure, but it would be easier for me if I do it after you complete this PR. Then I can just link directly the v3 libmediasoupclient branch to the mediasoup-broadcaster-demo.

[jmillan]

Sure, but it would be easier for me if I do it after you complete this PR. Then I can just link directly the v3 libmediasoupclient branch to the mediasoup-broadcaster-demo.

As for now this PR is complete, but we need to test it within mediasoup-broadcaster-demo ideally.

If you could make a PR for mediasoup-broadcaster-demo and point this libmediasoupclient branch in the scripts/get_deps.sh so we can test before merging to v3, would be great.

[tdrz]

OK, will do.

[tdrz]

@jmillan

Funny enough I can't build mediasoup-broadcaster-demo anymore:

/usr/bin/ld: [...]/webrtc/src/out/m84/obj/libwebrtc.a(latebindingsymboltable_linux.o): undefined reference to symbol 'dlclose@@GLIBC_2.2.5'
/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/9/../../../x86_64-linux-gnu/libdl.so: error adding symbols: DSO missing from command line

Did you encounter this problem before?

[tdrz]

I fixed it temporarily for me by adding libwebrtc to the target_link_libraries:

	# Public (interface) dependencies.
target_link_libraries(${PROJECT_NAME} PUBLIC
	${CPR_LIBRARIES}
	mediasoupclient
	webrtc_broadcaster
	${LIBWEBRTC_BINARY_PATH}/libwebrtc${CMAKE_STATIC_LIBRARY_SUFFIX}
)

[tdrz]

@ibc Done. Please have a look at

versatica/mediasoup-broadcaster-demo#10 and
versatica/mediasoup-demo#101

I couldn't solve the problem mentioned a couple of comments above in any other way than targeting the libwebrtc directly in the mediasoup-broadcaster-demo.

[jmillan]

We'll check it as soon as possible.

[tdrz]

I just discovered a bug, please wait with the review.

[tdrz]

Fixed.

[jmillan]

merged

[jmillan]

Thanks @copitembel!