Skip to content

fix(turbo-ignore): no longer attempt to use catalog protocol #10458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

chris-olszewski
Copy link
Member

Description

Fixes #10048

Do not attempt to use catalog protocol to fetch the specified version of turbo. Instead warn and fall back to inferring from turbo.json.

Testing Instructions

Added unit tests for this case

@chris-olszewski chris-olszewski requested a review from a team as a code owner May 8, 2025 13:57
@turbo-orchestrator turbo-orchestrator bot added the pkg: turbo-ignore packages/turbo-ignore label May 8, 2025
Copy link

vercel bot commented May 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:57pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:57pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:57pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:57pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:57pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:57pm
examples-svelte-web ❌ Failed (Inspect) May 8, 2025 1:57pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:57pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:57pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
turbo-site ⬜️ Skipped (Inspect) May 8, 2025 1:57pm

@chris-olszewski chris-olszewski enabled auto-merge (squash) May 8, 2025 13:59
@chris-olszewski chris-olszewski merged commit 8d65c4f into main May 8, 2025
43 of 44 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/fix_turbo_ignore_catalog branch May 8, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: turbo-ignore packages/turbo-ignore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

turbo-ignore is incompatible with pnpm catalogs
2 participants