Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turbo-ignore is incompatible with pnpm catalogs #10048

Open
1 task done
dBianchii opened this issue Feb 26, 2025 · 2 comments
Open
1 task done

turbo-ignore is incompatible with pnpm catalogs #10048

dBianchii opened this issue Feb 26, 2025 · 2 comments
Labels
kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage

Comments

@dBianchii
Copy link

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

https://github.com/dBianchii/turbo-ignore-pnpm-catalog-issue

Which canary version will you have in your reproduction?

2.4.3-canary.4

Enviroment information

CLI:
   Version: 2.4.3-canary.4
   Path to executable: /Users/gabrielbianchi/Documents/Github/turbo-ignore-pnpm-catalog-issue/node_modules/.pnpm/[email protected]/node_modules/turbo-darwin-arm64/bin/turbo
   Daemon status: Not running
   Package manager: pnpm9

Platform:
   Architecture: aarch64
   Operating system: macos
   WSL: false
   Available memory (MB): 10303
   Available CPU cores: 12

Environment:
   CI: None
   Terminal (TERM): xterm-256color
   Terminal program (TERM_PROGRAM): vscode
   Terminal program version (TERM_PROGRAM_VERSION): 1.97.2
   Shell (SHELL): /bin/zsh
   stdin: false

Expected behavior

It should not error when I run pnpx turbo-ignore, npx turbo-ignore, or pnpm turbo-ignore` while having a catalog: setting for my turbo package in my turborepo repository.

Actual behavior

When I run turbo-ignore from any package, I get this:

➜  turbo-ignore-pnpm-catalog-issue git:(main) ✗ pnpx turbo-ignore
≫   Using Turborepo to determine if this project is affected by the commit...

≫   Inferred "turbo-ignore-pnpm-catalog-issue" as workspace from "package.json"
≫   Inferred turbo version "catalog:" from "package.json"
≫   Using "build" as the task from the arguments
≫   Analyzing results of `npx -y turbo@catalog: run "build" --filter="turbo-ignore-pnpm-catalog-issue...[HEAD^]" --dry=json`
≫   UNKNOWN_ERROR: Command failed: npx -y turbo@catalog: run "build" --filter="turbo-ignore-pnpm-catalog-issue...[HEAD^]" --dry=json
npm error code EUNSUPPORTEDPROTOCOL
npm error Unsupported URL Type "catalog:": catalog:
npm error A complete log of this run can be found in: /Users/gabrielbianchi/.npm/_logs/2025-02-26T19_10_48_563Z-debug-0.log

✓ Proceeding with deployment
➜  turbo-ignore-pnpm-catalog-issue git:(main) ✗ 

To Reproduce

Clone repo, install deps with pnpm i, then run either pnpx turbo-ignore or npx turbo-ignore.

Additional context

No response

@dBianchii dBianchii added kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage labels Feb 26, 2025
@nextor2k
Copy link

nextor2k commented Feb 27, 2025

I can see that prune in 2.4.3 and 2.4.4 is also not working together with pnpm catalogs. should that be different issue?

@chris-olszewski
Copy link
Member

I can see that prune in 2.4.3 and 2.4.4 is also not working together with pnpm catalogs. should that be different issue?

Yes, please open a separate issue with a reproduction repository if possible.

cprussin added a commit to pyth-network/pyth-crosschain that referenced this issue Mar 16, 2025
This breaks `turbo-ignore`'s ability to detect the turbo version and results in
Vercel being unable to skip unneeded builds.

See vercel/turborepo#10048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

No branches or pull requests

3 participants