Skip to content

fix(ci): request ARG in every build stage #23049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Conversation

pront
Copy link
Member

@pront pront commented May 14, 2025

Summary

ARG needs to be requested in every build stage

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • The CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
      • ./scripts/check_changelog_fragments.sh
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

References

@pront pront requested a review from bfung May 14, 2025 15:04
@pront pront requested a review from a team as a code owner May 14, 2025 15:04
@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label May 14, 2025
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label May 14, 2025
@pront pront enabled auto-merge May 14, 2025 15:06
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: pront/tiny-fix-dockerfile
Commit report: 63175cb
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.43s Total Time

Copy link
Contributor

@bfung bfung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pront pront added this pull request to the merge queue May 14, 2025
Merged via the queue into master with commit 1a1050d May 14, 2025
62 of 64 checks passed
@pront pront deleted the pront/tiny-fix-dockerfile branch May 14, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants