chore(config): Convert top-level transforms enum to typetag #16572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the top-level `enum Transforms` into a boxed transform type. Serialization and deserialization are handled by `typetag`, and the `configurable_component` macro is enhanced to build out the necessary table entries to generate the schema bits dynamically from all of the components that are compiled into the current configuration.
bruceg
added
type: tech debt
✅ Deploy Preview for vector-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vrl-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
domain: topology
bruceg
added
the
ci-condition: integration tests enable
Regression Detector ResultsRun ID: a18da62b-ba7c-4389-8d1a-a605112daf5a ExplanationA regression test is an integrated performance test for The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:
Fine details of change detection per experiment.
|
tobz
approved these changes
Feb 24, 2023
| &self, | ||
| gen: &RefCell<SchemaGenerator>, | ||
| ) -> Result<SchemaObject, GenerateError> { | ||
| let tag_schema = schema::generate_internal_tagged_variant_schema("type".to_string(), { |
There was a problem hiding this comment.
This is fine for now, but one thing that makes me uneasy here is that we're hardcoding the code generation, essentially, to match what we have... but it could easily diverge from future refactoring aimed at making the output better for enums overall.
That, and we're hardcoding the tag field.
There was a problem hiding this comment.
This is all to say that it's fine for now, but it sure would be nice if we could figure out some way to drive more of this hand-written schema generation from the typetag-related data, if that makes sense.
There was a problem hiding this comment.
I'm open to that, but this seemed the best first path to solving it.
Regression Detector ResultsRun ID: 34d5f844-8677-4b40-820c-e5fba4fd4984 ExplanationA regression test is an integrated performance test for The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:
Fine details of change detection per experiment.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the top-level
enum Transformsinto a boxed transform type. Serialization and deserialization are handled bytypetag, and theconfigurable_componentmacro is enhanced to build out the necessary table entries to generate the schema bits dynamically from all of the components that are compiled into the current configuration.Note that this same approach is now possible for both the sources and sinks as well. This focuses on the transforms as the smallest step to prove it out for the other component types. Making it work for either sources or sinks should be able to be scoped down to just the actual sources and sinks and not need to touch support code like this does.