Skip to content

Convert sink components to use typetag #16702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bruceg opened this issue Mar 6, 2023 · 0 comments · Fixed by #17710
Closed

Convert sink components to use typetag #16702

bruceg opened this issue Mar 6, 2023 · 0 comments · Fixed by #17710
Labels
domain: sinks Anything related to the Vector's sinks type: tech debt A code change that does not add user value.

Comments

@bruceg
Copy link
Member

bruceg commented Mar 6, 2023

This is follow-up work to converting the transforms to use typetag. The required steps (for sinks) are:

  • Converting the SinkOuter.inner field from the Sinks enum to a Box<dyn SinkConfig>.
  • Manually implementing Configurable for Box<dyn SinkConfig>.
  • Adding the typetag macro wrapper to trait SinkConfig.
  • Adding the typetag macro wrapper to all impl SinkConfig for … blocks.
  • Moving the component description from enum Sinks into the individual component config struct's configurable_component macro.

Once both sources and sinks are done, there is some bits in the config macros that can be cleaned up, in particular in fn TypedComponent::get_component_desc_registration.

@bruceg bruceg added type: tech debt A code change that does not add user value. domain: sources Anything related to the Vector's sources labels Mar 6, 2023
@bruceg bruceg changed the title Convert source components to use typetag Convert source and sink components to use typetag Mar 6, 2023
@spencergilbert spencergilbert changed the title Convert source and sink components to use typetag Convert sink components to use typetag Apr 3, 2023
@spencergilbert spencergilbert added domain: sinks Anything related to the Vector's sinks and removed domain: sources Anything related to the Vector's sources labels Apr 3, 2023
@bruceg bruceg closed this as completed in 9cd5404 Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks type: tech debt A code change that does not add user value.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants