Handle symbol rename requests in the language server #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I missed this PR, but it looks good. When working in vim, I rarely have more than one document open so hadn't encountered those issues. 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the language server to handle requests to rename symbols, including component names,
@argand object field names, and block parameters.As part of this, I also discovered some inconsistencies in how we handle publishing diagnostics, since renames can impact correctness in files that didn't themselves change, so I fixed that as well as part of this PR.
As mentioned in #46, I brought over (the equivalent of) the
tsserver-plugintests for symbol renaming into the language server test suite.