Port tsserver-plugin tests for remaining uncovered language server functionality #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfreeman
force-pushed
the
additional-ls-tests
branch
from
517a672 to
d166b36
Compare
dfreeman
force-pushed
the
additional-ls-tests
branch
from
d166b36 to
70fe195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#45 added some baseline tests for the language server based partially on similar tests from the
tsserver-plugintest suite. This PR ports coverage for go-to-definition and hover functionality, rounding out coverage for everything the language server currently supports.Going forward we can port relevant tests as part of implementing new functionality, and when the language server can answer the same questions about a project as we could with
tsserver-plugin, we'll be able to drop that entire package and its test suite at once.Adding these tests also caught a couple small things that I'm fixing as part of this PR:
offsetToPositionbug when dealing with an offset on the last line of a file