Skip to content

Fix reboot for placeholder links #29140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2019
Merged

Fix reboot for placeholder links #29140

merged 3 commits into from
Jul 29, 2019

Conversation

ysds
Copy link
Contributor

@ysds ysds commented Jul 26, 2019

@ysds ysds requested a review from a team as a code owner July 26, 2019 09:04
@ysds ysds requested a review from patrickhlauke July 26, 2019 09:10
@ysds
Copy link
Contributor Author

ysds commented Jul 26, 2019

I'm not sure should backport this to v4.

@XhmikosR
Copy link
Member

XhmikosR commented Jul 27, 2019

Shouldn't we backport this?

@MartijnCuppens
Copy link
Member

Yup. I would wait for @patrickhlauke's aproval before merging this, just to be sure.

@patrickhlauke
Copy link
Member

patrickhlauke commented Jul 28, 2019

so if it's a placeholder, but it has been explicitly made focusable with tabindex="0" or any tabindex value > 0, this would suppress any focus indication? if so, not sure i'd agree...focus needs to be shown somehow.

(edit: hover, not so much...don't particularly care for it either way...but focus definitely needs to be denoted if it's been made explicitly focusable)

@ysds
Copy link
Contributor Author

ysds commented Jul 28, 2019

@patrickhlauke The after behavior is:

focus

Windows 10, Chrome 75

@XhmikosR XhmikosR merged commit 13b7416 into master Jul 29, 2019
@XhmikosR XhmikosR deleted the master-ysds-fix-reboot-link branch July 29, 2019 07:32
@XhmikosR
Copy link
Member

XhmikosR commented Jul 29, 2019

This needs to be manually backported to v4-dev. Can someone do it in my v4-dev-xmr branch?

@patrickhlauke
Copy link
Member

patrickhlauke commented Jul 29, 2019

urgh only noticed now, should probably also amend the preceding comment in the scss that talks about tabindex... (see #29162)

patrickhlauke added a commit that referenced this pull request Jul 29, 2019
@patrickhlauke
Copy link
Member

This needs to be manually backported to v4-dev. Can someone do it in my v4-dev-xmr branch?

done #29162

XhmikosR pushed a commit that referenced this pull request Jul 29, 2019
XhmikosR pushed a commit that referenced this pull request Jul 30, 2019
XhmikosR pushed a commit that referenced this pull request Jul 30, 2019
XhmikosR pushed a commit that referenced this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reboot for focused placeholder link
4 participants