-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
Fix reboot for placeholder links #29140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not sure should backport this to v4. |
Shouldn't we backport this? |
Yup. I would wait for @patrickhlauke's aproval before merging this, just to be sure. |
so if it's a placeholder, but it has been explicitly made focusable with (edit: hover, not so much...don't particularly care for it either way...but focus definitely needs to be denoted if it's been made explicitly focusable) |
@patrickhlauke The after behavior is: Windows 10, Chrome 75 |
This needs to be manually backported to v4-dev. Can someone do it in my v4-dev-xmr branch? |
urgh only noticed now, should probably also amend the preceding comment in the scss that talks about tabindex... (see #29162) |
done #29162 |
Fixes #28010