Skip to content

Reboot for focused placeholder link #28010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ysds opened this issue Jan 9, 2019 · 0 comments · Fixed by #29140
Closed

Reboot for focused placeholder link #28010

ysds opened this issue Jan 9, 2019 · 0 comments · Fixed by #29140
Labels

Comments

@ysds
Copy link
Contributor

ysds commented Jan 9, 2019

The focus states are taken into consideration, but I have a doubt about the necessity of them.

bootstrap/scss/_reboot.scss

Lines 199 to 211 in 39b7686

a:not([href]):not([tabindex]) {
color: inherit;
text-decoration: none;
@include hover-focus {
color: inherit;
text-decoration: none;
}
&:focus {
outline: 0;
}
}

It can be removed IMO. After:

a:not([href]) {
  color: inherit;
  text-decoration: none;

  @include hover {
    color: inherit;
    text-decoration: none;
  }
}

Related to: #21633, #21487, #19411

Any thoughts?

P.S: If we have plain-hover() mixin like the plain-hover-focus() mixin, can be more simplified:

a:not([href]) {
  @include plain-hover {
    color: inherit;
    text-decoration: none;
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants