-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
Neutralize link styles for placeholder links/named anchors #19411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Neutralize link styles for placeholder links/named anchors
If a clickable element have the same style and behaviour as a normal link (as in this case, as I assume that we still want it to be a link, or we should use a button), then we're keeping commonly known UX design patterns in the visual aspect of clickability, which is a way better UX approach than removing or change the default styling. |
default styling (in browsers) for anchors which lack an |
Oh sorry, I was referring more to the issue here #19402 (comment), as I think it will be easier for each individual developer to add their own style on placeholder links, than forcing everyone to do pointless overrides of the For your information, the default link behaviour is way easier to override than the |
if you're using a link without |
Yes, that is correct, but I think we're misunderstanding each other about the styling and override options that are available, once the The
It get ignored by the browser, and the developer is forced to write the following for it to be overridden:
|
@abstractic thanks, that makes your specific problem a bit clearer now. With #19874 you should be able to simply add |
You're welcome. I'm glad to help out. |
See twbs/bootstrap#19411 for reference Having different styles for <a> with and without href is the default browser behavior. We could also do link styling on a[href], but that would be hard to overwrite. The downside of this solution is that it is now hard to overwrite a:not([href]), but that is a much less common task.
Also prevented contrast ratio issues in pagination placeholder links that use the "active" class. Related to twbs/bootstrap#19402 and partially-based on twbs/bootstrap#19411 (thanks @patrickhlauke).
Also prevented contrast ratio issues in pagination placeholder links that use the "active" class. Related to twbs/bootstrap#19402 and partially-based on twbs/bootstrap#19411 (thanks @patrickhlauke).
Fixes #19402