Skip to content

Prevent select word wrap in Safari #27932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2019
Merged

Prevent select word wrap in Safari #27932

merged 2 commits into from
Jan 4, 2019

Conversation

MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Dec 27, 2018 •
edited
Loading

Fixes #24990.
Closes #25063

#25063 only fixes this for <select>s in .cards, but this behaviour should never occur, so it's better to deal with this in reboot.

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner December 27, 2018 19:15
@XhmikosR
Copy link
Member

Does this supersede #25063?

@MartijnCuppens
Copy link
Member Author

Yeah, #25063 will cause issues when words are too long in cards.

@XhmikosR
Copy link
Member

XhmikosR commented Dec 27, 2018 •
edited
Loading

Let's close it then when/if this lands.

@XhmikosR XhmikosR merged commit 83dc45b into v4-dev Jan 4, 2019
@XhmikosR XhmikosR deleted the v4-dev-martijncuppens-prevent-select-word-wrap branch January 4, 2019 09:40
@mdo mdo mentioned this pull request Jan 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
browser-bug css v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartijnCuppens @XhmikosR @mdo