Skip to content

Undo #22740, removing break-word from .card #25063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Undo #22740, removing break-word from .card #25063

wants to merge 7 commits into from

Conversation

mdo
Copy link
Member

@mdo mdo commented Dec 23, 2017

Fixes #24990 and fixes #25235 by undoing #22740.

This needs more thought in regards to what replace this with, but for now I want to at least have a fix for the identified problem. Consider this WIP until we have an alternative.

/cc @pat270

@pat270
Copy link
Contributor

pat270 commented Jan 15, 2018

Hey @mdo,
I was able to look into this today and it might be a browser bug. Safari doesn't seem to follow the definition of white-space: pre when a parent element has word-wrap: break-word https://www.w3.org/TR/css-text-3/#white-space-property, specifically "Lines only break at forced line breaks; content that does not fit within the block container overflows it".

word-break: break-all with child element white-space: pre works by the way.

Edit: To clarify this is in reference to #24990

@XhmikosR XhmikosR requested a review from a team as a code owner November 4, 2018 07:15
@XhmikosR XhmikosR deleted the undo-22740 branch January 4, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants