v4: Forms cleanup #19141
Merged
v4: Forms cleanup #19141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add container to fix padding in mobile views - Add large and small variations - Cross link grid classes and mixins - Fix up some words
Uses a new more specific class, adds some basic spacing, and clarifies that this class is only for validation feedback. Clears up the help text class question in #18704 (comment) and addresses the vertical spacing in #18703.
|
There's also this (again) #19004 but that might require revisiting all the |
|
@petetnt I'll add it to the todo list and see what I can do :). |
…and .form-control-legend to .col-form-legend) to reiterate use for only grid layouts
- Rather than use CSS hacks, let's avoid needing to hack anything - Creates a new Reboot entry to simply reset the appear of the temporal inputs, thereby avoiding the problem entirely - Less than ideal for conveying affordance on iOS, but given bugginess of the input itself, seems a decent tradeoff
|
Decent update to this today:
Have some more fiddling to do yet, but getting there. |
- Add lighter gray text to disabled state for .form-check - Separate radios and checkboxes example - Clarify docs
…into v4-forms-cleanup
- Includes new class - New docs to support it - Rearranged older docs
This was referenced May 11, 2016
|
Got the bulk of this done, but still have more changes to do as follow-up. |
|
I see a lot of stuff is commented out, not sure where the issue is regarding this? Screenshot:
|
This was referenced Jul 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch aims to overhaul a decent amount of forms styles and documentation with the hopes of getting it near final. It's still WIP and has a few more todos (noted below).
Quick screenshot
Changes
.form-control-labelso it avoids overriding grid-based form layouts and renders correctly in stacked forms..form-control-{sm/lg}classes to match small and large input classes, namely for vertical alignment of label and input in horizontal form groups..text-helpfor.form-control-feedback, designed specifically to only display temporary form validation feedback text in addition to normal help text.Todos
Form validation state colors aren't colorblind-friendly #19004: Color contrast and color blindness on validation colorsPunting on this for another time<select>s.