Skip to content

Consider renaming .radio and .checkbox #18390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cvrebert opened this issue Dec 1, 2015 · 3 comments
Closed

Consider renaming .radio and .checkbox #18390

cvrebert opened this issue Dec 1, 2015 · 3 comments
Labels

Comments

@cvrebert
Copy link
Collaborator

cvrebert commented Dec 1, 2015

Perhaps to something like .radio-block, .checkbox-block?
Given Bootstrap's general CSS class naming scheme, the current names (.radio, .checkbox) could be misinterpreted as base classes for which the .radio-inline, .checkbox-inline would be modifier classes; but that's not how they work (.radio.radio-inline isn't currently a sensical combination).

@guylepage3
Copy link

+1 Makes sense.

@halfmage
Copy link

halfmage commented Dec 2, 2015

.radio is block by default; I think .radio-block would be unnecessary. But .radio-inline should have the same behavior like .radio except the display method (like you mentioned).

@mdo mdo mentioned this issue Feb 9, 2016
5 tasks
@mdo
Copy link
Member

mdo commented May 11, 2016

Coming in #19141.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants