Skip to content

Prevent breadcrumb separator from getting underlined on hover when not using <ol> markup #18789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2016

Conversation

cvrebert
Copy link
Collaborator

@cvrebert cvrebert commented Jan 7, 2016

Uses wacky IE hack explained in the answers to http://stackoverflow.com/questions/8820286/how-to-remove-only-underline-from-abefore
Fixes #18733.
Closes #18740.

@cvrebert
Copy link
Collaborator Author

cvrebert commented Jan 7, 2016

Getting some obvious questions out of the way:

(1) No, the IE hack cannot be simplified to:

.breadcrumb-item:hover::before {
  text-decoration: underline;
  text-decoration: none;
}

It must be 2 separate rules.

(2) Yes, the IE hack does survive minification unscathed.

@cvrebert
Copy link
Collaborator Author

cvrebert commented Jan 7, 2016

CC: @mdo @patrickhlauke for review

@mdo
Copy link
Member

mdo commented Jan 7, 2016

Hmm, how was this not a problem in v3? Wonder if it's a problem of using floats as well?

@cvrebert
Copy link
Collaborator Author

cvrebert commented Jan 7, 2016

@mdo Because v3 required using <ol> markup for breadcrumbs. v4 lets you use a plain <div>; and indeed, the bug doesn't occur in v4 when using an <ol>.

@cvrebert cvrebert changed the title Prevent breadcrumb separator from getting underlined on hover when not using <ul> markup Prevent breadcrumb separator from getting underlined on hover when not using <ol> markup Jan 7, 2016
bassjobsen and others added 2 commits January 7, 2016 00:43
…ned on :hover when not using <ol> markup

Fixes #18733, except in IE9-11
Closes #18740
…over when not using <ol> markup

Fixes #18733 in IE9-11
Also adds comments to the code explaining this and #18740.
@cvrebert
Copy link
Collaborator Author

@mdo Any further feedback?

@mdo
Copy link
Member

mdo commented Jan 17, 2016

Taking a look at a few ideas this weekend.

@mdo
Copy link
Member

mdo commented Jan 17, 2016

Ah, shit, I understand what's going on now. It's because the ::before is within the .breadcrumb-item, not actually before it. Rough.

mdo added a commit that referenced this pull request Jan 17, 2016
Prevent breadcrumb separator from getting underlined on hover when not using <ol> markup
@mdo mdo merged commit 8a0b8b6 into v4-dev Jan 17, 2016
@mdo mdo deleted the fix-18733-more branch January 17, 2016 23:45
@mdo mdo mentioned this pull request Jan 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants