Skip to content

remove underline under breadcrumb separator #18740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

remove underline under breadcrumb separator #18740

wants to merge 2 commits into from

Conversation

bassjobsen
Copy link
Contributor

closes #18733

@cvrebert
Copy link
Collaborator

cvrebert commented Jan 1, 2016

Refs http://stackoverflow.com/questions/8820286/how-to-remove-only-underline-from-abefore
Sounds like some testing against various browsers will be necessary.

@cvrebert cvrebert changed the title remove underline under separator remove underline under breadcrumb separator Jan 1, 2016
@cvrebert
Copy link
Collaborator

cvrebert commented Jan 7, 2016

Confirmed in Chrome, Firefox, and Safari 9. Now to try IE...
inline-block testcase for IE: http://jsbin.com/jobire/edit?html,css

@cvrebert
Copy link
Collaborator

cvrebert commented Jan 7, 2016

The fix doesn't work in IE9-11. It does work in MS Edge.

@cvrebert
Copy link
Collaborator

cvrebert commented Jan 7, 2016

Really weird, but setting text-decoration: underline and then later text-decoration: none, both on the pseudo-element, seems to fix it in IE9-11. Confirmed via Sauce testing.
Credit: http://stackoverflow.com/a/32120247/3342739

cvrebert pushed a commit that referenced this pull request Jan 7, 2016
@bassjobsen @cvrebert
In modern browsers, prevent breadcrumb separator from getting underli…
a13c2e5 
…ned on :hover when not using <ul> markup

Fixes #18733, except in IE9-11
Closes #18740
cvrebert added a commit that referenced this pull request Jan 7, 2016
@cvrebert
In IE9-11, prevent breadcrumb separator from getting underlined on :h…
41d51bc 
…over when not using <ul> markup

Fixes #18733 in IE9-11
Also adds comments to the code explaining this and #18740.
cvrebert added a commit that referenced this pull request Jan 7, 2016
@cvrebert
In IE9-11, prevent breadcrumb separator from getting underlined on :h…
86cdc26 
…over when not using <ul> markup

Fixes #18733 in IE9-11
Also adds comments to the code explaining this and #18740.
@cvrebert cvrebert mentioned this pull request Jan 7, 2016
Merged
@cvrebert
Copy link
Collaborator

cvrebert commented Jan 7, 2016

Superseded by #18789, which includes your commit with the commit message tweaked,

@cvrebert cvrebert closed this Jan 7, 2016
cvrebert pushed a commit that referenced this pull request Jan 7, 2016
@bassjobsen @cvrebert
In modern browsers, prevent breadcrumb separator from getting underli…
53958da 
…ned on :hover when not using <ol> markup

Fixes #18733, except in IE9-11
Closes #18740
cvrebert added a commit that referenced this pull request Jan 7, 2016
@cvrebert
In IE9-11, prevent breadcrumb separator from getting underlined on :h…
86caa76 
…over when not using <ol> markup

Fixes #18733 in IE9-11
Also adds comments to the code explaining this and #18740.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bassjobsen @cvrebert