v4: Custom forms (disabled state, revamp, etc) #18771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Less nesting with more specific classes - New class names for most elements to avoid unnecessary and potentially confusing shorthand - Require new class and markup for the description (though it's only necessary for disable states, it's now part of the entire component's markup for all states just in case) - Change up colors and variables for regular and disabled states
- add more details on custom checkboxes and radios for how we handle the states and how the css works - create a disabled custom checkboxes and radios example
| } | ||
| .file-custom { | ||
|
|
||
| .custom-file-control { |
There was a problem hiding this comment.
Rule set contains (13/10) properties
There was a problem hiding this comment.
@mdo Looks like there's a SCSS-Lint rule we should disable?
| .file-custom { | ||
|
|
||
| // scss-lint:disable DuplicateProperty | ||
| .custom-file-control { |
There was a problem hiding this comment.
Rule set contains (13/10) properties
mdo
added a commit
that referenced
this pull request
Jan 6, 2016
v4: Custom forms (disabled state, revamp, etc)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashes the changes from #17921 and makes some additional changes:
.custom-select/cc @markau