Skip to content

added disabled state for custom form elements #17815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

janhocevar
Copy link

No description provided.

@patrickhlauke
Copy link
Member

Pro-tip: you can update a PR by pushing changes to it, without the need to open/close lots of separate ones...

Also, it would be nice to have a bit of a description of what your PR is about (e.g. a use case that's currently not sufficiently addressed by Bootstrap, and perhaps even a quick demo of what your proposed patch adds).

/cc @mdo

@janhocevar
Copy link
Author

the title kinda says what this PR does. custom form elements (checkbox and radio button) have grayish background, so this is replaced by default white background, and if input is disabled, grey background colour is added with not-allowed cursor along with it.

@mdo
Copy link
Member

mdo commented Nov 13, 2015

I swear I had disabled states in this already... will have to double check on that before I merge here. Swear I wrote something somewhere :).

@mdo mdo added the on-hold label Nov 13, 2015
@mdo
Copy link
Member

mdo commented Nov 13, 2015

Also #17921.

@mdo
Copy link
Member

mdo commented Jan 6, 2016

Fix coming in #18771. Thanks though!

@mdo mdo closed this Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants