Skip to content

Multiple input group addon #18498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 108 commits into from
Closed

Conversation

vicary
Copy link

@vicary vicary commented Dec 9, 2015

Resubmit to v4-dev branch.

Fixes #17927

See this plunker for a live demo.

kkirsche and others added 30 commits June 22, 2015 08:35
While this is correct that it was not being set, I did not notice any visible difference in Chrome on OS X when it is not set.

Fixes twbs#16683
Changed LESS to Less and author to Twitter, Inc.
Fix twbs#16973

As 30px was hard coded for the following attribute values: `width`, `height`, and `font-size`, I have used the same pixel formula for each of these three as the `@carousel-control-width` is a percent value not a pixel value in variables.less
Fix twbs#17011

Update .travis.yml
Have Travis CI use Ruby 2.0.0
[skip sauce]
[skip validator]
Mention themes contact info in CONTRIBUTING.md
Separated link not actually separated
Update support for Meteor 1.2
Mention Chrome meta-bug on Wall of Browser Bugs
Docs - clarify purpose of CSS class .in to .fade
[skip sauce]
Add CSS portion of IE10 viewport bug workaround to docs & examples
This change uses Bootstrap's existing `js/.jshintrc` file
to configure Hound's hosted JSHint instance.

It leaves existing JavaScript linting as-is
because Hound does not support ESLint or JSCS yet.

On each pull request to Bootstrap,
Hound will comment on any JavaScript style violations in-line,
like this:

![screenshot](https://images.thoughtbot.com/hound/javascript-example.png)

If you update the pull request to adopt a suggestion,
the comment will be hidden.

It leaves the existing linting done by Grunt + Travis.

Hound is free for open source projects
and is open source itself:

https://github.com/thoughtbot/hound
mikexstudios and others added 17 commits November 28, 2015 17:25
Updated SRI hashes in docs for CDN links
Add Wall of Browser Bugs entry for twbs#18365

See http://bugzil.la/1228802

[skip sauce]
[skip validator]
Made comment more clear.
Clarify comment in button-groups.less
[skip sauce]
[skip validator]
Mention Mozilla Firefox meta-bug on Wall of Browser Bugs
https://bugzilla.mozilla.org/show_bug.cgi?id=1230801

[skip sauce]
Grunt: Factor out new docs-github task
Check-in the v4 notice and themes link in the docs
Add Wall of Browser Bugs entry related to twbs#16028

https://bugs.webkit.org/show_bug.cgi?id=151933

[skip sauce]
1. Invert `:first-child` into `:not(:last-child)` and vice versa
2. Remove double border at the left of `.form-control`
3. Shifts negative margins of `.btn` and `.btn-group` to retain
rightmost border when using at the left of `.form-control`.

grunt.registerTask('prep-release', ['dist', 'docs', 'jekyll:github', 'htmlmin', 'compress']);
grunt.registerTask('prep-release', ['dist', 'docs', 'docs-github', 'compress']);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long.

@cvrebert
Copy link
Collaborator

cvrebert commented Dec 9, 2015

@vicary You're going to need to craft a new patch with v4-dev as your starting point. master and v4-dev have diverged too much for a patch against master to apply to v4-dev anymore.

@vicary
Copy link
Author

vicary commented Dec 9, 2015

@cvrebert Not sure but can I rebase to v4-dev?

@cvrebert
Copy link
Collaborator

cvrebert commented Dec 9, 2015

Since almost all the files basically got rewritten when we ported the code from LESS to Sass, rebasing is very unlikely to usefully work.

@vicary
Copy link
Author

vicary commented Dec 9, 2015

Ok I'll start again from v4-dev.

@vicary vicary deleted the multiple-input-group-addon branch December 9, 2015 07:58
@cvrebert
Copy link
Collaborator

cvrebert commented Dec 9, 2015

Successor: #18500

@twbs twbs locked and limited conversation to collaborators Dec 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.