-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
Documentation clean up and consistency. #17625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -28,7 +28,7 @@ restrictions: | |||
[`Normalize`](https://github.com/necolas/normalize.css) (open them in | |||
their respective repositories). | |||
|
|||
* Please **do not** open issues regarding the official themes offered on <http://themes.getbootstrap.com/>. Instead, please email any questions or feedback regarding those themes to `themes AT getbootstrap DOT com`. | |||
* Please **do not** open issues regarding the official themes offered on <http://themes.getbootstrap.com/>. Instead, please email any questions or feedback regarding those themes to <themes@getbootstrap.com>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was formatted that way as an anti-spam defense measure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting... To prevent from spammers that scrape GitHub for email addresses?
I'll revert this change.
Addressed your feedback @cvrebert. |
@@ -124,7 +124,7 @@ provide as much detail and context as possible. | |||
|
|||
## Pull requests | |||
|
|||
Good pull requests—patches, improvements, new features—are a fantastic | |||
Good pull requests - patches, improvements, and new features - are a fantastic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Em dashes don't require spaces on the sides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the reason I made this change is because when I first read this line without the spaces, it seems like "request-patches" was one hyphenated word. The spaces symbolize that it is rather offset parenthetical information. (See: http://www.grammarly.com/handbook/punctuation/dash/2/dash-parenthetical-information/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It comes down to style/preference. As a rule, em dashes do indeed not require spaces. However, most newspapers that employ the Associated Press styleguide do include spaces. Personally, I find em dashes more readable with spaces either side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use a number of em dashes throughout our docs I believe—let's leave it as-is for now for consistency with what's written most other places.
Merged with a couple tweaks. Thanks! |
[skip sauce]
@mdo - just some general clean up of your
.md
files. 👍