Skip to content

Remove .center-block class from the docs #19443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RyanZim opened this issue Mar 8, 2016 · 10 comments
Closed

Remove .center-block class from the docs #19443

RyanZim opened this issue Mar 8, 2016 · 10 comments

Comments

@RyanZim
Copy link

RyanZim commented Mar 8, 2016

.center-block was removed in #19102, but the docs still mention it.

Also this should be added to the Migration Guide.

@RyanZim RyanZim changed the title Remove .center-block class from the Docs [v4] Remove .center-block class from the Docs Mar 8, 2016
@cvrebert cvrebert added this to the v4.0.0-alpha.3 milestone Mar 9, 2016
@cvrebert cvrebert changed the title [v4] Remove .center-block class from the Docs Remove .center-block class from the docs Mar 9, 2016
@RyanZim
Copy link
Author

RyanZim commented Mar 10, 2016

It seems that this was updated in v4-dev docs/ on GitHub but hasn't been compiled to the gh-pages branch.

@XhmikosR
Copy link
Member

@cvrebert: shouldn't we close this? I mean, gh-pages is from master so this is expected.

@cvrebert
Copy link
Collaborator

@XhmikosR There are still references to it in the docs:

bootstrap (v4-dev) $ ack center-block docs/
docs/assets/scss/_component-examples.scss
302:  .center-block:not(img) {

docs/content/images.md
63:  <img data-src="holder.js/200x200" class="img-rounded center-block" alt="A generic square placeholder image with rounded corners">
67:<img src="..." class="img-rounded center-block" alt="...">

docs/examples/carousel/index.html
132:          <img class="featurette-image img-fluid center-block" data-src="holder.js/500x500/auto" alt="Generic placeholder image">
144:          <img class="featurette-image img-fluid center-block" data-src="holder.js/500x500/auto" alt="Generic placeholder image">
156:          <img class="featurette-image img-fluid center-block" data-src="holder.js/500x500/auto" alt="Generic placeholder image">

docs/index.html
90:    <img class="img-fluid center-block" src="{{ site.baseurl }}/assets/img/bs-themes.png" alt="Bootstrap Themes" width="1024" height="388">

@XhmikosR
Copy link
Member

Ah, that's why #19339 happens.

I'll try to have a look later.

@XhmikosR
Copy link
Member

So, how do you want to proceed @cvrebert? m-x-auto doesn't set display: block. Should I add a custom class now?

@RyanZim
Copy link
Author

RyanZim commented Mar 11, 2016

#19343 is a feature request for .display-block, .display-inline, and display-inline-block. Why not include all of them while we're at it?

@cvrebert
Copy link
Collaborator

@XhmikosR I favor @RyanZim's suggestion.

@XhmikosR
Copy link
Member

All right, I'll leave it to someone else for the time being.

cvrebert pushed a commit that referenced this issue Apr 6, 2016
Replace the leftover instances with .m-x-auto (and .d-block when necessary)
Closes #19665
Refs #19102
[skip sauce]
@RyanZim
Copy link
Author

RyanZim commented Apr 6, 2016

Closing due to a0a157d.

@RyanZim RyanZim closed this as completed Apr 6, 2016
@cvrebert
Copy link
Collaborator

cvrebert commented Apr 6, 2016

<3

cvrebert added a commit that referenced this issue Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants